Doing some updates to the magpie #6925

ytimocin · 2023-12-06T19:53:21Z

Description

Opened this PR not from the fork because there are some actions that I would like to test and can't be triggered from a fork.

Updating some packages
Changing the way we append string to an array
Adding missing context

Type of change

This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).
Fixes: Upgrade modules in magpie and do a cleanup #6932

Auto-generated summary

`🤖[deprecated] Generated by Copilot at db8fccb`

Summary

🐰📦🚀

Updated the magpiego bindings for RabbitMQ and servicebus to use context and improve performance and readability. Also upgraded some dependencies in go.mod to use the latest versions.

Oh we're the magpiego crew and we know what to do
We import the context and we update the go.mod
We heave away and haul away with RabbitMQ
And we make the servicebus go faster and smoother too

Walkthrough

Import context package and use context.Background() to create a context for RabbitMQ operations (link, link)
Simplify message body conversion to string in GetMessage function for RabbitMQ binding (link)
Remove unused fmt package from servicebus.go file (link)
Update go.mod file to use latest versions of mongo-driver, compress, crypto, and text packages (link, link, link)

radius-functional-tests · 2023-12-06T19:57:52Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	radius-project/radius
Commit ref	`49f9c7f`
Unique ID	5591595fad
Image tag	pr-5591595fad

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-5591595fad
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-5591595fad
controller test image location: ghcr.io/radius-project/dev/controller:pr-5591595fad
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-5591595fad
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting samples functional tests...
⌛ Starting shared functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting ucp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting daprrp functional tests...
✅ ucp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ msgrp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ daprrp functional tests succeeded
✅ shared functional tests succeeded

github-actions · 2023-12-06T20:04:52Z

Test Results

3 002 tests ±0 2 992 ✔️ ±0 3m 11s ⏱️ ±0s
  257 suites ±0     10 💤 ±0
      1 files ±0       0 ❌ ±0

Results for commit 00fd2d1. ± Comparison against base commit 1de017a.

♻️ This comment has been updated with latest results.

github-actions · 2023-12-06T20:05:11Z

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

Your PR branch coverage: 65.4 %
main branch coverage: 65.4 %
diff coverage: 0 %

The coverage result does not include the functional test coverage.

kachawla · 2023-12-06T21:07:38Z

test/magpiego/bindings/rabbitmq.go

+	ctx := context.Background()
 	err = ch.PublishWithContext(
 		ctx,


This is weird that ctx wasn't defined before.. how was it compiling?

Super wierd! Is this a global variable defined somewhere? If that's the case we should clean it up.

https://github.com/radius-project/radius/blob/main/test/magpiego/bindings/mongo.go#L12

We should fix that. Doesn't have to be this PR.

Storing a context in a global variable like that is going to lead to a lot more confusion.

Fixed it in this PR

radius-functional-tests · 2023-12-06T22:54:38Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	radius-project/radius
Commit ref	`ad69f5c`
Unique ID	3a59bc6d98
Image tag	pr-3a59bc6d98

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-3a59bc6d98
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-3a59bc6d98
controller test image location: ghcr.io/radius-project/dev/controller:pr-3a59bc6d98
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-3a59bc6d98
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting samples functional tests...
⌛ Starting ucp functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting shared functional tests...
✅ ucp functional tests succeeded
✅ msgrp functional tests succeeded
✅ samples functional tests succeeded
✅ kubernetes functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ daprrp functional tests succeeded
✅ shared functional tests succeeded

github-actions · 2023-12-06T23:01:58Z

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

Your PR branch coverage: 65.4 %
main branch coverage: 65.4 %
diff coverage: 0 %

The coverage result does not include the functional test coverage.

github-actions · 2023-12-07T01:52:50Z

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

Your PR branch coverage: 65.4 %
main branch coverage: 65.4 %
diff coverage: 0 %

The coverage result does not include the functional test coverage.

radius-functional-tests · 2023-12-07T17:43:29Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	radius-project/radius
Commit ref	`82af438`
Unique ID	53fadf6007
Image tag	pr-53fadf6007

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-53fadf6007
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-53fadf6007
controller test image location: ghcr.io/radius-project/dev/controller:pr-53fadf6007
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-53fadf6007
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting datastoresrp functional tests...
⌛ Starting ucp functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting shared functional tests...
⌛ Starting samples functional tests...
⌛ Starting kubernetes functional tests...
✅ ucp functional tests succeeded
✅ msgrp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ samples functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ daprrp functional tests succeeded
✅ shared functional tests succeeded

ytimocin · 2023-12-07T18:30:23Z

test/magpiego/go.mod

Upgrading all modules to keep things up-to-date

radius-functional-tests · 2023-12-07T18:31:43Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	radius-project/radius
Commit ref	`c72b0ac`
Unique ID	743d790e09
Image tag	pr-743d790e09

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-743d790e09
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-743d790e09
controller test image location: ghcr.io/radius-project/dev/controller:pr-743d790e09
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-743d790e09
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting samples functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting daprrp functional tests...
✅ ucp functional tests succeeded
⌛ Starting shared functional tests...
✅ msgrp functional tests succeeded
✅ samples functional tests succeeded
✅ kubernetes functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ daprrp functional tests succeeded
✅ shared functional tests succeeded

rynowak

Awesome, thanks for doing the cleanup.

github-actions · 2023-12-07T18:39:59Z

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

Your PR branch coverage: 65.4 %
main branch coverage: 65.4 %
diff coverage: 0 %

The coverage result does not include the functional test coverage.

radius-functional-tests · 2023-12-07T19:32:45Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	radius-project/radius
Commit ref	`467d4f1`
Unique ID	7086d65e79
Image tag	pr-7086d65e79

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-7086d65e79
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-7086d65e79
controller test image location: ghcr.io/radius-project/dev/controller:pr-7086d65e79
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-7086d65e79
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting daprrp functional tests...
⌛ Starting shared functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting ucp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting samples functional tests...
✅ ucp functional tests succeeded
✅ msgrp functional tests succeeded
✅ samples functional tests succeeded
✅ kubernetes functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ daprrp functional tests succeeded
✅ shared functional tests succeeded

github-actions · 2023-12-07T19:42:38Z

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

Your PR branch coverage: 65.4 %
main branch coverage: 65.4 %
diff coverage: 0 %

The coverage result does not include the functional test coverage.

Signed-off-by: ytimocin <[email protected]>

radius-functional-tests · 2023-12-07T22:51:07Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	radius-project/radius
Commit ref	`00fd2d1`
Unique ID	32715182ce
Image tag	pr-32715182ce

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-32715182ce
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-32715182ce
controller test image location: ghcr.io/radius-project/dev/controller:pr-32715182ce
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-32715182ce
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting datastoresrp functional tests...
⌛ Starting samples functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting shared functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting ucp functional tests...
⌛ Starting kubernetes functional tests...
✅ ucp functional tests succeeded
✅ samples functional tests succeeded
✅ msgrp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ daprrp functional tests succeeded
✅ shared functional tests succeeded

github-actions · 2023-12-07T22:59:51Z

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

Your PR branch coverage: 65.4 %
main branch coverage: 65.4 %
diff coverage: 0 %

The coverage result does not include the functional test coverage.

ytimocin requested review from a team as code owners December 6, 2023 19:53

ytimocin had a problem deploying to functional-tests December 6, 2023 19:53 — with GitHub Actions Failure

ytimocin force-pushed the ytimocin/magpieUpdates branch from db8fccb to 49f9c7f Compare December 6, 2023 19:54

ytimocin temporarily deployed to functional-tests December 6, 2023 19:54 — with GitHub Actions Inactive

kachawla previously approved these changes Dec 6, 2023

View reviewed changes

ytimocin dismissed kachawla’s stale review via e6b787f December 6, 2023 22:51

ytimocin force-pushed the ytimocin/magpieUpdates branch from 49f9c7f to e6b787f Compare December 6, 2023 22:51

ytimocin had a problem deploying to functional-tests December 6, 2023 22:51 — with GitHub Actions Failure

ytimocin force-pushed the ytimocin/magpieUpdates branch from e6b787f to ad69f5c Compare December 6, 2023 22:51

ytimocin temporarily deployed to functional-tests December 6, 2023 22:51 — with GitHub Actions Inactive

kachawla previously approved these changes Dec 6, 2023

View reviewed changes

ytimocin force-pushed the ytimocin/magpieUpdates branch from ad69f5c to 82af438 Compare December 7, 2023 01:42

ytimocin temporarily deployed to functional-tests December 7, 2023 01:42 — with GitHub Actions Inactive

ytimocin dismissed kachawla’s stale review via c72b0ac December 7, 2023 18:29

ytimocin temporarily deployed to functional-tests December 7, 2023 18:29 — with GitHub Actions Inactive

ytimocin commented Dec 7, 2023

View reviewed changes

test/magpiego/go.mod Outdated

Copy link

Contributor Author

ytimocin Dec 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrading all modules to keep things up-to-date

ytimocin requested review from rynowak and kachawla December 7, 2023 18:31

rynowak approved these changes Dec 7, 2023

View reviewed changes

ytimocin force-pushed the ytimocin/magpieUpdates branch from c72b0ac to 467d4f1 Compare December 7, 2023 19:31

ytimocin temporarily deployed to functional-tests December 7, 2023 19:31 — with GitHub Actions Inactive

kachawla approved these changes Dec 7, 2023

View reviewed changes

ytimocin added 2 commits December 7, 2023 14:49

Doing some updates to the magpie

d300458

Signed-off-by: ytimocin <[email protected]>

Upgrade the Go modules

00fd2d1

Signed-off-by: ytimocin <[email protected]>

ytimocin force-pushed the ytimocin/magpieUpdates branch from 467d4f1 to 00fd2d1 Compare December 7, 2023 22:49

ytimocin temporarily deployed to functional-tests December 7, 2023 22:50 — with GitHub Actions Inactive

ytimocin merged commit fb0fe3c into main Dec 7, 2023
19 checks passed

ytimocin deleted the ytimocin/magpieUpdates branch December 7, 2023 23:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Doing some updates to the magpie #6925

Doing some updates to the magpie #6925

ytimocin commented Dec 6, 2023 •

edited

Loading

radius-functional-tests bot commented Dec 6, 2023 •

edited

Loading

github-actions bot commented Dec 6, 2023 •

edited

Loading

github-actions bot commented Dec 6, 2023

kachawla Dec 6, 2023

rynowak Dec 6, 2023

ytimocin Dec 6, 2023

rynowak Dec 6, 2023

ytimocin Dec 6, 2023

radius-functional-tests bot commented Dec 6, 2023 •

edited

Loading

github-actions bot commented Dec 6, 2023

github-actions bot commented Dec 7, 2023

radius-functional-tests bot commented Dec 7, 2023 •

edited

Loading

ytimocin Dec 7, 2023

radius-functional-tests bot commented Dec 7, 2023 •

edited

Loading

rynowak left a comment

github-actions bot commented Dec 7, 2023

radius-functional-tests bot commented Dec 7, 2023 •

edited

Loading

github-actions bot commented Dec 7, 2023

radius-functional-tests bot commented Dec 7, 2023 •

edited

Loading

github-actions bot commented Dec 7, 2023

Doing some updates to the magpie #6925

Doing some updates to the magpie #6925

Conversation

ytimocin commented Dec 6, 2023 • edited Loading

Description

Type of change

Auto-generated summary

🤖[deprecated] Generated by Copilot at db8fccb

Summary

Walkthrough

radius-functional-tests bot commented Dec 6, 2023 • edited Loading

Radius functional test overview

Test Status

github-actions bot commented Dec 6, 2023 • edited Loading

Test Results

github-actions bot commented Dec 6, 2023

kachawla Dec 6, 2023

Choose a reason for hiding this comment

rynowak Dec 6, 2023

Choose a reason for hiding this comment

ytimocin Dec 6, 2023

Choose a reason for hiding this comment

rynowak Dec 6, 2023

Choose a reason for hiding this comment

ytimocin Dec 6, 2023

Choose a reason for hiding this comment

radius-functional-tests bot commented Dec 6, 2023 • edited Loading

Radius functional test overview

Test Status

github-actions bot commented Dec 6, 2023

github-actions bot commented Dec 7, 2023

radius-functional-tests bot commented Dec 7, 2023 • edited Loading

Radius functional test overview

Test Status

ytimocin Dec 7, 2023

Choose a reason for hiding this comment

radius-functional-tests bot commented Dec 7, 2023 • edited Loading

Radius functional test overview

Test Status

rynowak left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 7, 2023

radius-functional-tests bot commented Dec 7, 2023 • edited Loading

Radius functional test overview

Test Status

github-actions bot commented Dec 7, 2023

radius-functional-tests bot commented Dec 7, 2023 • edited Loading

Radius functional test overview

Test Status

github-actions bot commented Dec 7, 2023

ytimocin commented Dec 6, 2023 •

edited

Loading

`🤖[deprecated] Generated by Copilot at db8fccb`

radius-functional-tests bot commented Dec 6, 2023 •

edited

Loading

github-actions bot commented Dec 6, 2023 •

edited

Loading

radius-functional-tests bot commented Dec 6, 2023 •

edited

Loading

radius-functional-tests bot commented Dec 7, 2023 •

edited

Loading

radius-functional-tests bot commented Dec 7, 2023 •

edited

Loading

radius-functional-tests bot commented Dec 7, 2023 •

edited

Loading

radius-functional-tests bot commented Dec 7, 2023 •

edited

Loading