Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix namespace in devcontainer feature publishing #6970

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

rynowak
Copy link
Contributor

@rynowak rynowak commented Dec 20, 2023

Description

This change corrects the "feature namespace" from devcontainer-features -> radius-project/devcontainer-features. Our goal is to be consistent with https://containers.dev/collections

The previous attempt failed due to missing the org name. See failing workflow here: https://github.com/radius-project/radius/actions/runs/7278838782/job/19833934876

Please explain the changes you've made.

Type of change

  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #issue_number

Auto-generated summary

copilot:all

This change corrects the "feature namespace" from `devcontainer-features` -> `radius-project/devcontainer-features`. Our goal is to be consistent with https://containers.dev/collections

The previous attempt failed due to missing the org name. See failing workflow here: https://github.com/radius-project/radius/actions/runs/7278838782/job/19833934876

Signed-off-by: Ryan Nowak <[email protected]>
@rynowak rynowak requested review from a team as code owners December 20, 2023 17:42
@rynowak
Copy link
Contributor Author

rynowak commented Dec 20, 2023

@rynowak
Copy link
Contributor Author

rynowak commented Dec 20, 2023

Unfortunately I have to push this to main in order to test it out...... Since the impact of this is very low I'm going to bypass PR checks and do that.

@rynowak rynowak merged commit 48c97fe into main Dec 20, 2023
16 of 17 checks passed
@rynowak rynowak deleted the rynowak/fix-devcontainerfeaturepublish branch December 20, 2023 17:45
Copy link

65.5

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

  • Your PR branch coverage: 65.5 %
  • main branch coverage: 65.5 %
  • diff coverage: 0 %

The coverage result does not include the functional test coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant