Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove rad app switch reference from the error message #7083

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Remove rad app switch reference from the error message #7083

merged 1 commit into from
Jan 29, 2024

Conversation

akshayrohilla
Copy link
Contributor

Description

Updated the error message to remove the reference of rad application switch command.

Type of change

  • This pull request fixes a bug in Radius and has an approved issue (issue link required).

Fixes: #7078

@akshayrohilla
Fixes: radius-project#7078
a71884c 
Signed-off-by: Akshay Rohilla <[email protected]>
@akshayrohilla akshayrohilla requested review from a team as code owners January 27, 2024 20:27
@akshayrohilla akshayrohilla changed the title Fixes: #7078 Remove rad app switch reference from the error message Jan 27, 2024
ytimocin
ytimocin reviewed Jan 29, 2024
View reviewed changes
pkg/cli/clivalidation.go
@@ -166,8 +166,8 @@ func RequireApplicationArgs(cmd *cobra.Command, args []string, workspace workspa
}

if applicationName == "" {
return "", fmt.Errorf("no application name provided and no default application set, " +
"either pass in an application name or set a default application by using `rad application switch`")
return "", fmt.Errorf("no application name provided, " +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc/ @AaronCrawfis @willtsai

@radius-functional-tests
Copy link

radius-functional-tests bot commented Jan 29, 2024 •
edited
Loading

Radius functional test overview

🔍 Go to test action run

Name Value
Repository akshayrohilla/radius
Commit ref a71884c
Unique ID 20d25027b6
Image tag pr-20d25027b6
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-20d25027b6
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-20d25027b6
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-20d25027b6
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-20d25027b6
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting kubernetes functional tests...
⌛ Starting samples functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting ucp functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting shared functional tests...
✅ samples functional tests succeeded
✅ kubernetes functional tests succeeded
✅ msgrp functional tests succeeded
✅ daprrp functional tests succeeded
✅ ucp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ shared functional tests succeeded

@shalabhms
Copy link
Contributor

Thanks @akshayrohilla for your contribution !

@shalabhms shalabhms closed this Jan 29, 2024
@shalabhms shalabhms reopened this Jan 29, 2024
@radius-functional-tests
Copy link

radius-functional-tests bot commented Jan 29, 2024 •
edited
Loading

Radius functional test overview

🔍 Go to test action run

Name Value
Repository akshayrohilla/radius
Commit ref a71884c
Unique ID 5c7e4bbc82
Image tag pr-5c7e4bbc82
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-5c7e4bbc82
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-5c7e4bbc82
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-5c7e4bbc82
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-5c7e4bbc82
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting kubernetes functional tests...
⌛ Starting shared functional tests...
⌛ Starting samples functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting ucp functional tests...
⌛ Starting datastoresrp functional tests...
✅ kubernetes functional tests succeeded
✅ samples functional tests succeeded
✅ msgrp functional tests succeeded
✅ ucp functional tests succeeded
✅ daprrp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ shared functional tests succeeded

@ytimocin
Copy link
Contributor

Thanks for your contribution @akshayrohilla !

@ytimocin ytimocin merged commit 3164e53 into radius-project:main Jan 29, 2024
30 checks passed
willdavsmith pushed a commit to willdavsmith/radius that referenced this pull request Mar 4, 2024
@akshayrohilla @willdavsmith
Remove rad app switch reference from the error message (radius-projec…
db139bc 
…t#7083)

# Description

Updated the error message to remove the reference of rad application
switch command.

## Type of change

<!--

Please select **one** of the following options that describes your
change and delete the others. Clearly identifying the type of change you
are making will help us review your PR faster, and is used in authoring
release notes.

If you are making a bug fix or functionality change to Radius and do not
have an associated issue link please create one now.

-->

- This pull request fixes a bug in Radius and has an approved issue
(issue link required).

<!--

Please update the following to link the associated issue. This is
required for some kinds of changes (see above).

-->

Fixes: radius-project#7078

Signed-off-by: Akshay Rohilla <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronCrawfis AaronCrawfis AaronCrawfis approved these changes

@shalabhms shalabhms shalabhms approved these changes

@ytimocin ytimocin ytimocin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI error message points to a non-existing command
4 participants
@akshayrohilla @shalabhms @ytimocin @AaronCrawfis