Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating patch api def for applications resource #7182

Merged
merged 1 commit into from
Feb 21, 2024
Merged

updating patch api def for applications resource #7182

merged 1 commit into from
Feb 21, 2024

Conversation

vishwahiremat
Copy link
Contributor

Description

Updated patch api def on typespec for applications resource.

Type of change

  • This pull request fixes a bug in Radius and has an approved issue (issue link required).
  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #issue_number

@vishwahiremat
fix update api
95fe34f 
Signed-off-by: Vishwanath Hiremath <[email protected]>
@vishwahiremat vishwahiremat requested review from a team as code owners February 16, 2024 22:15
youngbupark
youngbupark approved these changes Feb 16, 2024
View reviewed changes
Copy link

@youngbupark youngbupark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch :)

@radius-functional-tests
Copy link

radius-functional-tests bot commented Feb 16, 2024 •
edited
Loading

Radius functional test overview

🔍 Go to test action run

Name Value
Repository vishwahiremat/radius
Commit ref 95fe34f
Unique ID 292290ee17
Image tag pr-292290ee17
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-292290ee17
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-292290ee17
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-292290ee17
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-292290ee17
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting msgrp functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting ucp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting samples functional tests...
⌛ Starting datastoresrp functional tests...
❌ daprrp functional test cancelled. Please check the logs for more details
✅ msgrp functional tests succeeded
✅ samples functional tests succeeded
✅ kubernetes functional tests succeeded
✅ ucp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ shared functional tests succeeded

@vishwahiremat vishwahiremat mentioned this pull request Feb 21, 2024
Merged
@ytimocin ytimocin merged commit 275b861 into radius-project:main Feb 21, 2024
16 checks passed
willdavsmith pushed a commit to willdavsmith/radius that referenced this pull request Feb 23, 2024
@vishwahiremat @willdavsmith
updating patch api def for applications resource (radius-project#7182)
7fcc454 
# Description

Updated patch api def on typespec for applications resource.

## Type of change

<!--

Please select **one** of the following options that describes your
change and delete the others. Clearly identifying the type of change you
are making will help us review your PR faster, and is used in authoring
release notes.

If you are making a bug fix or functionality change to Radius and do not
have an associated issue link please create one now.

-->

- This pull request fixes a bug in Radius and has an approved issue
(issue link required).
- This pull request is a minor refactor, code cleanup, test improvement,
or other maintenance task and doesn't change the functionality of Radius
(issue link optional).

<!--

Please update the following to link the associated issue. This is
required for some kinds of changes (see above).

-->

Fixes: #issue_number

Signed-off-by: Vishwanath Hiremath <[email protected]>
Signed-off-by: willdavsmith <[email protected]>
willdavsmith pushed a commit to willdavsmith/radius that referenced this pull request Mar 4, 2024
@vishwahiremat @willdavsmith
updating patch api def for applications resource (radius-project#7182)
7995338 
# Description

Updated patch api def on typespec for applications resource.

## Type of change

<!--

Please select **one** of the following options that describes your
change and delete the others. Clearly identifying the type of change you
are making will help us review your PR faster, and is used in authoring
release notes.

If you are making a bug fix or functionality change to Radius and do not
have an associated issue link please create one now.

-->

- This pull request fixes a bug in Radius and has an approved issue
(issue link required).
- This pull request is a minor refactor, code cleanup, test improvement,
or other maintenance task and doesn't change the functionality of Radius
(issue link optional).

<!--

Please update the following to link the associated issue. This is
required for some kinds of changes (see above).

-->

Fixes: #issue_number

Signed-off-by: Vishwanath Hiremath <[email protected]>
willdavsmith pushed a commit to willdavsmith/radius that referenced this pull request Apr 8, 2024
@vishwahiremat @willdavsmith
updating patch api def for applications resource (radius-project#7182)
30855b3 
# Description

Updated patch api def on typespec for applications resource.

## Type of change

<!--

Please select **one** of the following options that describes your
change and delete the others. Clearly identifying the type of change you
are making will help us review your PR faster, and is used in authoring
release notes.

If you are making a bug fix or functionality change to Radius and do not
have an associated issue link please create one now.

-->

- This pull request fixes a bug in Radius and has an approved issue
(issue link required).
- This pull request is a minor refactor, code cleanup, test improvement,
or other maintenance task and doesn't change the functionality of Radius
(issue link optional).

<!--

Please update the following to link the associated issue. This is
required for some kinds of changes (see above).

-->

Fixes: #issue_number

Signed-off-by: Vishwanath Hiremath <[email protected]>
Signed-off-by: willdavsmith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kachawla kachawla kachawla approved these changes

@youngbupark youngbupark youngbupark approved these changes

@ytimocin ytimocin ytimocin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vishwahiremat @ytimocin @youngbupark @kachawla