-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change test organization for shared tests. #7227
Change test organization for shared tests. #7227
Conversation
c396bb0
to
465e4a8
Compare
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
465e4a8
to
e9d422c
Compare
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
e9d422c
to
19c2fcc
Compare
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
19c2fcc
to
d0afa45
Compare
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
test/functional-portable/corerp/cloud/mechanics/aws_mechanics_test.go
Outdated
Show resolved
Hide resolved
test/functional-portable/corerp/cloud/resources/persistent_volume_test.go
Outdated
Show resolved
Hide resolved
...ortable/corerp/cloud/resources/testdata/recipes/test-terraform-recipes/azure-storage/main.tf
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code changes here look like what I expected for moving/separated tests.
However, there's some things I'd like to know the answers to before we merge:
- I'd like to figure out a plan for mis-categorized or badly-designed tests. This might look like, diffing the set of tests we actually have against the set of tests we want to have, and then filing bugs for follow-up.
- I'd like to talk about how we're going to clean up references to shared code (like
RPTest
). - I'd like to talk about how we're going to organize recipes.
It's good if the assets (like bicep or tf files) used in each test can be isolated and self-contained. Right now the references to recipes are kinda all over. I know you didn't make this mess, but we shouldn't miss the opportunity to clean it up 😎
6b275c5
to
8f6d92f
Compare
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
4d36eb5
to
0be3e1c
Compare
Signed-off-by: vinayada1 <[email protected]>
Signed-off-by: vinayada1 <[email protected]>
Signed-off-by: vinayada1 <[email protected]>
Signed-off-by: vinayada1 <[email protected]>
Signed-off-by: vinayada1 <[email protected]>
Signed-off-by: vinayada1 <[email protected]>
31560d0
to
24c3e2f
Compare
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
long-running test is failed because it cannot get the secret to log in azure. it is expected. |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Signed-off-by: vinayada1 <[email protected]>
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Signed-off-by: vinayada1 <[email protected]>
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
build/test.mk
Outdated
test-functional-shared: ## Runs shared functional tests | ||
CGO_ENABLED=1 $(GOTEST_TOOL) ./test/functional/shared/... -timeout ${TEST_TIMEOUT} -v -parallel 10 $(GOTEST_OPTS) | ||
test-functional-shared: test-functional-corerp-noncloud test-functional-corerp-cloud ## Runs all Core RP functional tests (both cloud and non-cloud) | ||
@echo "$(ARROW) Running corerp functional tests" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this supposed to be blank? If this is here for historical purposes, when can it be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean it should be test-functional-corerp instead of test-functional-shared? This PR will still run against the old workflow in the main branch which uses "shared" instead of "corerp". I will change the workflow in a separate PR once the "corerp" directory structure is checked in
Signed-off-by: vinayada1 <[email protected]>
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Description
Type of change
Fixes: Fixes part of #6588. This is a part of a multi-PR fix