Change open portal hyperlinks #7229

gpltaylor · 2024-03-02T11:30:34Z

Description

Allow Connection Graph output resources name to be a link within the console output.

Type of change

This pull request fixes a bug in Radius and has an approved issue (issue link required).
This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #7170

pkg/cli/cmd/app/connections/display_test.go

radius-functional-tests · 2024-03-02T19:32:01Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	gpltaylor/radius
Commit ref	`0769f9d`
Unique ID	2cd9d490a5
Image tag	pr-2cd9d490a5

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-2cd9d490a5
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-2cd9d490a5
controller test image location: ghcr.io/radius-project/dev/controller:pr-2cd9d490a5
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-2cd9d490a5
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting msgrp functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting ucp functional tests...
⌛ Starting shared functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting samples functional tests...
✅ msgrp functional tests succeeded
✅ samples functional tests succeeded
✅ ucp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ daprrp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ shared functional tests succeeded

rynowak · 2024-03-03T21:08:07Z

Hey @gpltaylor thanks for helping with this! It looks like the PR is on the right track. I left a suggestion about testing. I'll leave it up to you whether you want to refactor or not. Let me know when you're done and we'll re-review the PR.

rynowak · 2024-03-03T21:08:32Z

In the mean time I've approved the functional tests.

radius-functional-tests · 2024-03-03T21:09:02Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	gpltaylor/radius
Commit ref	`7d22226`
Unique ID	d7ae32c525
Image tag	pr-d7ae32c525

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-d7ae32c525
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-d7ae32c525
controller test image location: ghcr.io/radius-project/dev/controller:pr-d7ae32c525
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-d7ae32c525
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
❌ Test tool installation for kubernetes failed. Please check the logs for more details
❌ Failed to install Radius for shared functional test. Please check the logs for more details
❌ Failed to install Radius for kubernetes functional test. Please check the logs for more details
❌ shared functional test failed. Please check the logs for more details
❌ kubernetes functional test failed. Please check the logs for more details
❌ samples functional test cancelled. Please check the logs for more details
❌ datastoresrp functional test cancelled. Please check the logs for more details

gpltaylor · 2024-03-04T21:07:52Z

@rynowak @radius-project/radius-core-team
I'm happy with the work done. Can you please review this PR and merge if you're happy to do so.

rynowak · 2024-03-04T23:40:30Z

Can you rebase this? There are merge conflicts with main. If you help let me know.

rynowak

Code changes look good. Thanks @gpltaylor. This will to have conflicts resolved before it goes in.

\# Changes Cosmetic changes to the connections graph output. Does not affect the functionality of the core system. fixes #7170 Signed-off-by: gpltaylor <[email protected]>

Signed-off-by: gpltaylor <[email protected]>

gpltaylor · 2024-03-05T19:00:45Z

@rynowak I think I managed to Rebase and get my code up-to-date.
Please let me know if this is ok.

rynowak

Looks great! Thanks for helping with this.

rynowak · 2024-03-06T01:50:08Z

I'll merge this after the functional tests pass.

radius-functional-tests · 2024-03-06T01:50:39Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	gpltaylor/radius
Commit ref	`ff8630b`
Unique ID	db7abc0e0c
Image tag	pr-db7abc0e0c

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-db7abc0e0c
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-db7abc0e0c
controller test image location: ghcr.io/radius-project/dev/controller:pr-db7abc0e0c
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-db7abc0e0c
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting datastoresrp functional tests...
⌛ Starting samples functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting shared functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting kubernetes functional tests...
✅ msgrp functional tests succeeded
✅ ucp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ samples functional tests succeeded
✅ daprrp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ shared functional tests succeeded

gpltaylor requested review from a team as code owners March 2, 2024 11:30

gpltaylor commented Mar 2, 2024

View reviewed changes

pkg/cli/cmd/app/connections/display_test.go Outdated Show resolved Hide resolved

gpltaylor temporarily deployed to functional-tests March 3, 2024 21:08 — with GitHub Actions Inactive

rynowak previously approved these changes Mar 4, 2024

View reviewed changes

kachawla previously approved these changes Mar 5, 2024

View reviewed changes

gpltaylor dismissed stale reviews from kachawla and rynowak via 0769f9d March 5, 2024 18:33

gpltaylor added 3 commits March 5, 2024 18:54

Change open portal hyperlinks

9a41bae

\# Changes Cosmetic changes to the connections graph output. Does not affect the functionality of the core system. fixes #7170 Signed-off-by: gpltaylor <[email protected]>

Clean up

c8e842a

Signed-off-by: gpltaylor <[email protected]>

Remove to.Ptr to confirm with code

938e478

Signed-off-by: gpltaylor <[email protected]>

Merge branch 'main' into 7170-link

ff8630b

rynowak approved these changes Mar 6, 2024

View reviewed changes

rynowak temporarily deployed to functional-tests March 6, 2024 01:50 — with GitHub Actions Inactive

rynowak merged commit 58c7447 into radius-project:main Mar 6, 2024
16 checks passed

Reshrahim mentioned this pull request Mar 28, 2024

Official Release 0.32.0 #7405

Merged

gpltaylor deleted the 7170-link branch May 7, 2024 16:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change open portal hyperlinks #7229

Change open portal hyperlinks #7229

gpltaylor commented Mar 2, 2024

radius-functional-tests bot commented Mar 2, 2024 •

edited

Loading

rynowak commented Mar 3, 2024

rynowak commented Mar 3, 2024

radius-functional-tests bot commented Mar 3, 2024 •

edited

Loading

gpltaylor commented Mar 4, 2024

rynowak commented Mar 4, 2024

rynowak left a comment

gpltaylor commented Mar 5, 2024

rynowak left a comment

rynowak commented Mar 6, 2024

radius-functional-tests bot commented Mar 6, 2024 •

edited

Loading

Change open portal hyperlinks #7229

Change open portal hyperlinks #7229

Conversation

gpltaylor commented Mar 2, 2024

Description

Type of change

radius-functional-tests bot commented Mar 2, 2024 • edited Loading

Radius functional test overview

Test Status

rynowak commented Mar 3, 2024

rynowak commented Mar 3, 2024

radius-functional-tests bot commented Mar 3, 2024 • edited Loading

Radius functional test overview

Test Status

gpltaylor commented Mar 4, 2024

rynowak commented Mar 4, 2024

rynowak left a comment

Choose a reason for hiding this comment

gpltaylor commented Mar 5, 2024

rynowak left a comment

Choose a reason for hiding this comment

rynowak commented Mar 6, 2024

radius-functional-tests bot commented Mar 6, 2024 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Mar 2, 2024 •

edited

Loading

radius-functional-tests bot commented Mar 3, 2024 •

edited

Loading

radius-functional-tests bot commented Mar 6, 2024 •

edited

Loading