Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not fail for codecov error #7429

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Do not fail for codecov error #7429

merged 1 commit into from
Apr 2, 2024

Conversation

youngbupark
Copy link

Description

Tokenless upload (forked repo pr) can be throttled like below. This is to unblock the build even if codecov is failed.

==> Uploader SHASUM verified (e3ea28a069fe174eb99ac2ffb523bfb55d5d29a7cfd93ef48cde12e9b552b492  codecov)
info - 2024-04-02 16:12:29,890 -- ci service found: github-actions
debug - 2024-04-02 16:12:29,893 -- versioning system found: <class 'codecov_cli.helpers.versioning_systems.GitVersioningSystem'>
debug - 2024-04-02 16:12:29,893 -- Loading config from .codecov.yml
debug - 2024-04-02 16:12:29,895 -- Starting create commit process --- {"commit_sha": "babae5be5a94d[64](https://github.com/radius-project/radius/actions/runs/8525878516/job/23353867349?pr=7390#step:7:65)fd7976b80e94905255116e920", "parent_sha": null, "pr": "7390", "branch": "vishwahiremat/recipe_show_cmd", "slug": "radius-project/radius", "token": null, "service": "github", "enterprise_url": null}
info - 2024-04-02 16:12:30,144 -- The PR is happening in a forked repo. Using tokenless upload.
info - 2024-04-02 16:12:30,334 -- Process Commit creating complete
debug - 2024-04-02 16:12:30,334 -- Commit creating result --- {"result": "RequestResult(error=RequestError(code='HTTP Error 429', params={}, description='{\"detail\":\"Tokenless has reached GitHub rate limit. Please upload using a token: https://docs.codecov.com/docs/adding-the-codecov-token. Expected available in 1188 seconds.\"}'), warnings=[], status_code=429, text='{\"detail\":\"Tokenless has reached GitHub rate limit. Please upload using a token: https://docs.codecov.com/docs/adding-the-codecov-token. Expected available in 1188 seconds.\"}')"}
error - 2024-04-02 16:12:30,334 -- Commit creating failed: {"detail":"Tokenless has reached GitHub rate limit. Please upload using a token: https://docs.codecov.com/docs/adding-the-codecov-token. Expected available in 1188 seconds."}
Error: Codecov: Failed to properly create commit: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1

Type of change

  • This pull request fixes a bug in Radius and has an approved issue (issue link required).
  • This pull request adds or changes features of Radius and has an approved issue (issue link required).
  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #issue_number

Signed-off-by: Young Bu Park <[email protected]>
@youngbupark youngbupark requested review from a team as code owners April 2, 2024 16:22
@youngbupark youngbupark temporarily deployed to functional-tests April 2, 2024 16:22 — with GitHub Actions Inactive
@radius-functional-tests
Copy link

radius-functional-tests bot commented Apr 2, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository radius-project/radius
Commit ref a07e54a
Unique ID funcc9383ea12e
Image tag pr-funcc9383ea12e
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcc9383ea12e
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcc9383ea12e
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-funcc9383ea12e
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcc9383ea12e
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting msgrp functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting shared functional tests...
⌛ Starting ucp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting cli functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting samples functional tests...
✅ msgrp functional tests succeeded
✅ ucp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ samples functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ cli functional tests succeeded
✅ shared functional tests succeeded

Copy link

github-actions bot commented Apr 2, 2024

Test Results

3 135 tests  ±0   3 128 ✅ ±0   3m 31s ⏱️ +4s
  261 suites ±0       7 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit a07e54a. ± Comparison against base commit 72dfb50.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.79%. Comparing base (72dfb50) to head (a07e54a).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7429      +/-   ##
==========================================
- Coverage   63.80%   63.79%   -0.01%     
==========================================
  Files         416      416              
  Lines       23436    23436              
==========================================
- Hits        14954    14952       -2     
- Misses       7223     7224       +1     
- Partials     1259     1260       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@youngbupark youngbupark merged commit 1da9e8e into main Apr 2, 2024
18 checks passed
@youngbupark youngbupark deleted the youngp/continue-codecov branch April 2, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants