Remove unused parameters #7473

ytimocin · 2024-04-08T05:00:44Z

Description

Remove unused parameters

Type of change

This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

radius-functional-tests · 2024-04-08T05:02:06Z

Radius functional test overview

Name	Value
Repository	radius-project/radius
Commit ref	`837ef92`
Unique ID	funcb4d1dd3573
Image tag	pr-funcb4d1dd3573

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcb4d1dd3573
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcb4d1dd3573
controller test image location: ghcr.io/radius-project/dev/controller:pr-funcb4d1dd3573
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcb4d1dd3573
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting samples functional tests...
⌛ Starting shared functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting ucp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting datastoresrp functional tests...
✅ samples functional tests succeeded
✅ msgrp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ ucp functional tests succeeded
✅ daprrp functional tests succeeded
✅ cli functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ shared functional tests succeeded

codecov · 2024-04-08T05:11:23Z

Codecov Report

Attention: Patch coverage is 81.63265% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 63.83%. Comparing base (0a3d68a) to head (6c63ff0).

Files	Patch %	Lines
pkg/cli/clients/management.go	0.00%	4 Missing ⚠️
pkg/cli/deployment/diagnostics.go	0.00%	2 Missing ⚠️
...erp/frontend/controller/applications/graph_util.go	60.00%	2 Missing ⚠️
pkg/sdk/health.go	0.00%	2 Missing ⚠️
pkg/ucp/store/cosmosdb/cosmosdbstorageclient.go	0.00%	2 Missing ⚠️
pkg/cli/cmd/bicep/publish/publish.go	50.00%	1 Missing ⚠️
pkg/cli/config/radyaml.go	0.00%	0 Missing and 1 partial ⚠️
pkg/cli/helm/contourclient.go	0.00%	1 Missing ⚠️
.../cli/kubernetes/portforward/application_watcher.go	50.00%	1 Missing ⚠️
...orerp/frontend/controller/applications/getgraph.go	0.00%	1 Missing ⚠️
... and 1 more

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #7473   +/-   ##
=======================================
  Coverage   63.83%   63.83%           
=======================================
  Files         417      417           
  Lines       23494    23494           
=======================================
  Hits        14997    14997           
  Misses       7227     7227           
  Partials     1270     1270

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-04-08T05:11:24Z

Test Results

3 145 tests ±0 3 138 ✅ ±0 3m 26s ⏱️ -17s
261 suites ±0 7 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit 6c63ff0. ± Comparison against base commit 0a3d68a.

♻️ This comment has been updated with latest results.

rynowak · 2024-04-08T17:40:38Z

pkg/cli/helm/contourclient.go

@@ -120,7 +120,7 @@ func AddContourValues(helmChart *chart.Chart, options ContourOptions) error {
 		}

 		servicePortsNode := serviceNode["ports"].(map[string]any)
-		if serviceNode == nil {


Was this a bug? looks like it might have been. This is why cleanup like this is helpful 👍

rynowak

Thanks for doing this cleanup 👍

kachawla

👏

Signed-off-by: ytimocin <[email protected]>

radius-functional-tests · 2024-04-08T19:06:53Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	radius-project/radius
Commit ref	`6c63ff0`
Unique ID	funcffe84063cf
Image tag	pr-funcffe84063cf

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcffe84063cf
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcffe84063cf
controller test image location: ghcr.io/radius-project/dev/controller:pr-funcffe84063cf
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcffe84063cf
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting daprrp functional tests...
⌛ Starting shared functional tests...
⌛ Starting ucp functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting samples functional tests...
⌛ Starting cli functional tests...
⌛ Starting datastoresrp functional tests...
✅ ucp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ daprrp functional tests succeeded
✅ msgrp functional tests succeeded
✅ cli functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ shared functional tests succeeded

# Description Remove unused parameters ## Type of change - This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional). Signed-off-by: ytimocin <[email protected]>

This reverts commit 9a540af.

ytimocin requested review from a team as code owners April 8, 2024 05:00

ytimocin temporarily deployed to functional-tests April 8, 2024 05:00 — with GitHub Actions Inactive

rynowak reviewed Apr 8, 2024

View reviewed changes

rynowak approved these changes Apr 8, 2024

View reviewed changes

kachawla approved these changes Apr 8, 2024

View reviewed changes

Remove unused parameters

6c63ff0

Signed-off-by: ytimocin <[email protected]>

ytimocin force-pushed the ytimocin/removeUnusedParams branch from 837ef92 to 6c63ff0 Compare April 8, 2024 19:05

ytimocin temporarily deployed to functional-tests April 8, 2024 19:05 — with GitHub Actions Inactive

ytimocin merged commit 74a3f25 into main Apr 8, 2024
20 checks passed

ytimocin deleted the ytimocin/removeUnusedParams branch April 8, 2024 19:22

sk593 added a commit that referenced this pull request Apr 15, 2024

Revert "Remove unused parameters (#7473)"

dd099c8

This reverts commit 9a540af.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove unused parameters #7473

Remove unused parameters #7473

ytimocin commented Apr 8, 2024

radius-functional-tests bot commented Apr 8, 2024 •

edited

Loading

codecov bot commented Apr 8, 2024 •

edited

Loading

github-actions bot commented Apr 8, 2024 •

edited

Loading

rynowak Apr 8, 2024

rynowak left a comment

kachawla left a comment

radius-functional-tests bot commented Apr 8, 2024 •

edited

Loading

Remove unused parameters #7473

Remove unused parameters #7473

Conversation

ytimocin commented Apr 8, 2024

Description

Type of change

radius-functional-tests bot commented Apr 8, 2024 • edited Loading

Radius functional test overview

Test Status

codecov bot commented Apr 8, 2024 • edited Loading

Codecov Report

github-actions bot commented Apr 8, 2024 • edited Loading

Test Results

rynowak Apr 8, 2024

Choose a reason for hiding this comment

rynowak left a comment

Choose a reason for hiding this comment

kachawla left a comment

Choose a reason for hiding this comment

radius-functional-tests bot commented Apr 8, 2024 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Apr 8, 2024 •

edited

Loading

codecov bot commented Apr 8, 2024 •

edited

Loading

github-actions bot commented Apr 8, 2024 •

edited

Loading

radius-functional-tests bot commented Apr 8, 2024 •

edited

Loading