Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating contour, stern, cloudformation, and k8s controller runtime versions #7498

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Updating contour, stern, cloudformation, and k8s controller runtime versions #7498

merged 1 commit into from
Apr 17, 2024

Conversation

ytimocin
Copy link
Contributor

Description

Updating contour, stern, cloudformation, and k8s controller runtime versions

Type of change

  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

@ytimocin ytimocin requested review from a team as code owners April 12, 2024 22:12
rynowak
rynowak reviewed Apr 13, 2024
View reviewed changes
pkg/controller/service.go
@@ -71,10 +72,11 @@ func (s *Service) Run(ctx context.Context) error {
port := s.Options.Config.Server.Port
healthProbePort := *s.Options.Config.WorkerServer.Port
mgr, err := ctrl.NewManager(s.Options.K8sConfig, ctrl.Options{
Logger: logger,
CertDir: s.TLSCertDir,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, do you know how the certificates should be configured now that this option has changed? The certificates are needed outside of test scenarios.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also this setting: https://github.com/radius-project/radius/pull/7498/files#diff-b31c03e05358c6faab6e77c96909e14e14eeb0dc09412ede3329625adc197fa9R85. Can we sync offline on this one? Trying to understand where else we can need this property.

rynowak
rynowak requested changes Apr 13, 2024
View reviewed changes
Copy link
Contributor

@rynowak rynowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks right, but there are two things to double check.

  • Can we remove KubeContext from the options if it's unused?
  • How do we configure certificates?

@ytimocin ytimocin force-pushed the ytimocin/updateDeps/v3 branch from 6bbc1cf to c0927a3 Compare April 15, 2024 15:24
@ytimocin ytimocin requested a review from rynowak April 15, 2024 15:26
@ytimocin ytimocin force-pushed the ytimocin/updateTFExec branch from 417a07b to 4cf84fe Compare April 15, 2024 18:58
ytimocin
ytimocin commented Apr 15, 2024
View reviewed changes
pkg/recipes/driver/terraform.go Outdated
@@ -152,7 +152,7 @@ func (d *terraformDriver) Delete(ctx context.Context, opts DeleteOptions) error
// prepareRecipeResponse populates the recipe response from the module output named "result" and the
// resources deployed by the Terraform module. The outputs and resources are retrieved from the input Terraform JSON state.
func (d *terraformDriver) prepareRecipeResponse(ctx context.Context, definition recipes.EnvironmentDefinition, tfState *tfjson.State) (*recipes.RecipeOutput, error) {
if tfState == nil || (*tfState == tfjson.State{}) {
if tfState == nil || reflect.DeepEqual(*tfState, tfjson.State{}) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This branch will be rebased after #7497 gets merged in.

@ytimocin ytimocin force-pushed the ytimocin/updateTFExec branch from 4cf84fe to bfd036d Compare April 15, 2024 21:08
Base automatically changed from ytimocin/updateTFExec to main April 17, 2024 21:05
@ytimocin ytimocin force-pushed the ytimocin/updateDeps/v3 branch from c0927a3 to 4656f9f Compare April 17, 2024 21:08
@ytimocin ytimocin temporarily deployed to functional-tests April 17, 2024 21:08 — with GitHub Actions Inactive
@radius-functional-tests
Copy link

radius-functional-tests bot commented Apr 17, 2024 •
edited
Loading

Radius functional test overview

🔍 Go to test action run

Name Value
Repository radius-project/radius
Commit ref 4656f9f
Unique ID func426dc061a3
Image tag pr-func426dc061a3
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func426dc061a3
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func426dc061a3
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func426dc061a3
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func426dc061a3
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting msgrp functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting cli functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting samples functional tests...
⌛ Starting shared functional tests...
⌛ Starting ucp functional tests...
✅ msgrp functional tests succeeded
✅ samples functional tests succeeded
✅ kubernetes functional tests succeeded
✅ daprrp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ cli functional tests succeeded
✅ ucp functional tests succeeded
✅ shared functional tests succeeded

@github-actions GitHub Actions
Copy link

Test Results

3 117 tests  ±0   3 110 ✅ ±0   3m 33s ⏱️ ±0s
  259 suites ±0       7 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 4656f9f. ± Comparison against base commit 5a03b05.

@codecov Codecov
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.59%. Comparing base (5a03b05) to head (4656f9f).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7498   +/-   ##
=======================================
  Coverage   63.59%   63.59%           
=======================================
  Files         414      414           
  Lines       23292    23292           
=======================================
  Hits        14812    14812           
  Misses       7219     7219           
  Partials     1261     1261

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ytimocin ytimocin merged commit ef2c468 into main Apr 17, 2024
19 checks passed
@ytimocin ytimocin deleted the ytimocin/updateDeps/v3 branch April 17, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kachawla kachawla kachawla approved these changes

@rynowak rynowak rynowak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ytimocin @rynowak @kachawla