Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused test artifacts #7824

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Conversation

kachawla
Copy link
Contributor

Description

Some of the tests have been updated to remove dependency from Azure resources (example), but the relevant scripts that created the actual resources weren't updated. This PR removes the code for resources no longer used. I'll manually delete the corresponding leftover resources from portal (all created over a year ago).

Type of change

  • This pull request fixes a bug in Radius and has an approved issue (issue link required).
  • This pull request adds or changes features of Radius and has an approved issue (issue link required).
  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #issue_number

Signed-off-by: karishma-chawla <[email protected]>
@kachawla kachawla requested review from a team as code owners August 20, 2024 23:01
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.07%. Comparing base (6e18608) to head (8310bdb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7824      +/-   ##
==========================================
+ Coverage   61.05%   61.07%   +0.02%     
==========================================
  Files         523      523              
  Lines       27466    27466              
==========================================
+ Hits        16768    16774       +6     
+ Misses       9212     9209       -3     
+ Partials     1486     1483       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kachawla kachawla temporarily deployed to functional-tests August 21, 2024 16:14 — with GitHub Actions Inactive
@radius-functional-tests
Copy link

radius-functional-tests bot commented Aug 21, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository kachawla/radius
Commit ref 8310bdb
Unique ID func8ec1d9397d
Image tag pr-func8ec1d9397d
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func8ec1d9397d
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func8ec1d9397d
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func8ec1d9397d
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func8ec1d9397d
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting datastoresrp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ datastoresrp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

@kachawla kachawla merged commit 875c5ca into radius-project:main Aug 21, 2024
27 checks passed
superbeeny pushed a commit to superbeeny/radius that referenced this pull request Aug 21, 2024
Some of the tests have been updated to remove dependency from Azure
resources
([example](https://github.com/radius-project/radius/pull/5623/files#diff-257cc4360838d4c154e45fb4ec7d997569a34170b1b81771ab0283911658568c)),
but the relevant scripts that created the actual resources weren't
updated. This PR removes the code for resources no longer used. I'll
manually delete the corresponding leftover resources from portal (all
created over a year ago).

Signed-off-by: karishma-chawla <[email protected]>
Co-authored-by: karishma-chawla <[email protected]>
Reshrahim pushed a commit to Reshrahim/radius that referenced this pull request Aug 27, 2024
Some of the tests have been updated to remove dependency from Azure
resources
([example](https://github.com/radius-project/radius/pull/5623/files#diff-257cc4360838d4c154e45fb4ec7d997569a34170b1b81771ab0283911658568c)),
but the relevant scripts that created the actual resources weren't
updated. This PR removes the code for resources no longer used. I'll
manually delete the corresponding leftover resources from portal (all
created over a year ago).

Signed-off-by: karishma-chawla <[email protected]>
Co-authored-by: karishma-chawla <[email protected]>
Signed-off-by: Reshma Abdul Rahim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants