Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove assets.yaml #7832

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Remove assets.yaml #7832

merged 1 commit into from
Aug 22, 2024

Conversation

lakshmimsft
Copy link
Contributor

Description

Cleaning up disabled workflow assets.yaml.

Type of change

  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (Remove/disable assets workflow #7800 ).

Fixes: #7800

@lakshmimsft lakshmimsft requested review from a team as code owners August 22, 2024 18:10
@radius-functional-tests
Copy link

radius-functional-tests bot commented Aug 22, 2024 •
edited
Loading

Radius functional test overview

🔍 Go to test action run

Name Value
Repository lakshmimsft/radius-mainfork
Commit ref d8ab4ef
Unique ID func4f361ac07c
Image tag pr-func4f361ac07c
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func4f361ac07c
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func4f361ac07c
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func4f361ac07c
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func4f361ac07c
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting datastoresrp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ corerp-cloud functional tests succeeded
✅ datastoresrp-cloud functional tests succeeded
✅ ucp-cloud functional tests succeeded

@codecov Codecov
Copy link

codecov bot commented Aug 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.06%. Comparing base (33d3d5e) to head (d8ab4ef).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7832      +/-   ##
==========================================
- Coverage   61.07%   61.06%   -0.01%     
==========================================
  Files         523      523              
  Lines       27466    27466              
==========================================
- Hits        16774    16772       -2     
- Misses       9209     9210       +1     
- Partials     1483     1484       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kachawla
kachawla approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@kachawla kachawla left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checking - are there any other related code paths as well that should be cleaned up as well?

@lakshmimsft lakshmimsft merged commit 7da87d4 into radius-project:main Aug 22, 2024
27 checks passed
@kachawla
Copy link
Contributor

Just checking - are there any other related code paths as well that should be cleaned up as well?

@lakshmimsft

Reshrahim pushed a commit to Reshrahim/radius that referenced this pull request Aug 27, 2024
@lakshmimsft @Reshrahim
Remove assets.yaml (radius-project#7832)
e8807cb 
# Description

Cleaning up disabled workflow assets.yaml.

## Type of change
- This pull request is a minor refactor, code cleanup, test improvement,
or other maintenance task and doesn't change the functionality of Radius
(radius-project#7800 ).

Fixes: radius-project#7800
Signed-off-by: Reshma Abdul Rahim <[email protected]>
@lakshmimsft
Copy link
Contributor Author

@kachawla I had searched codebase for any reference to assets.yaml and found none.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kachawla kachawla kachawla approved these changes

@ytimocin ytimocin ytimocin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove/disable assets workflow
3 participants
@lakshmimsft @kachawla @ytimocin