Update the timeout of the clean-up cluster step to 1h

[ytimocin]

Description

Update the timeout of the clean-up cluster step to 1h.

Type of change

• This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

[github-actions]

Unit Tests

3 366 tests  ±0   3 360 ✅ ±0   3m 57s ⏱️ -1s
  265 suites ±0       6 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit f1bd766. ± Comparison against base commit 69d6726.

♻️ This comment has been updated with latest results.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.07%. Comparing base (69d6726) to head (f1bd766).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #7938   +/-   ##
=======================================
  Coverage   61.07%   61.07%           
=======================================
  Files         531      531           
  Lines       28061    28061           
=======================================
  Hits        17138    17138           
  Misses       9427     9427           
  Partials     1496     1496           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sk593]

Do we need to have two cleanup cluster steps? These both seem to be part of the test job

[ytimocin]

One cleans up before the tests and the other one after the tests. This is to be extra defensive. We want to have a clean start before running the tests and want to make sure we delete everything after we run the tests.

[sk593]

makes sense. PR lgtm then

[radius-functional-tests]

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	radius-project/radius
Commit ref	7d22b2d
Unique ID	func7f3bc5d9d6
Image tag	pr-func7f3bc5d9d6

Click here to see the list of tools in the current test run

• gotestsum 1.12.0
• KinD: v0.20.0
• Dapr: 1.12.0
• Azure KeyVault CSI driver: 1.4.2
• Azure Workload identity webhook: 1.3.0
• Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func7f3bc5d9d6
• Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
• applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func7f3bc5d9d6
• controller test image location: ghcr.io/radius-project/dev/controller:pr-func7f3bc5d9d6
• ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func7f3bc5d9d6
• deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting datastoresrp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ datastoresrp-cloud functional tests succeeded
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

[lakshmimsft]

@ytimocin I am curious if this will alleviate the issue. If we are terminating the script in an hour and there are still resources/finalizers than need clean up, will they be cleaned up while the finalizers are still attached during the second run on the script? Based on the overlapping runs for multiple days, it seems like multiple runs of the script did not help clean it up.
Atleast we will not wait for the script to complete over an hour, so that is good.
let's try this. If it works, great, if not, maybe after the first run of the script, we can cycle through all resources in the namespace with 'Terminating' state and log them, so we narrow down what the finalizers are waiting on.

[ytimocin]

@ytimocin I am curious if this will alleviate the issue. If we are terminating the script in an hour and there are still resources/finalizers than need clean up, will they be cleaned up while the finalizers are still attached during the second run on the script? Based on the overlapping runs for multiple days, it seems like multiple runs of the script did not help clean it up. Atleast we will not wait for the script to complete over an hour, so that is good. let's try this. If it works, great, if not, maybe after the first run of the script, we can cycle through all resources in the namespace with 'Terminating' state and log them, so we narrow down what the finalizers are waiting on.

The problem with 6-hour timeout is that it doesn't do clean-up during that time. It just waits for the finalizers to finalize. But that doesn't happen. If the workflow waited for 6 days, it wouldn't also happen. The problem is something else.

I wanted to reduce the time to 1h so that we don't wait 6 hours for a run to be finalized.

Thanks for the feedback and the approval @lakshmimsft!

[radius-functional-tests]

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	radius-project/radius
Commit ref	f1bd766
Unique ID	func95acc5885e
Image tag	pr-func95acc5885e

Click here to see the list of tools in the current test run

• gotestsum 1.12.0
• KinD: v0.20.0
• Dapr: 1.12.0
• Azure KeyVault CSI driver: 1.4.2
• Azure Workload identity webhook: 1.3.0
• Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func95acc5885e
• Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
• applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func95acc5885e
• controller test image location: ghcr.io/radius-project/dev/controller:pr-func95acc5885e
• ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func95acc5885e
• deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting datastoresrp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ datastoresrp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded