Cherry picking the fix for helm chart version issue #8200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Description To find the correct helm chart version in our code, we search for the release major value but wildcard the patch value. We need to update the versioning logic during the Helm install to handle a few different cases: 1. If there is a pre-release version (i.e. -rc1, -rc2, etc), we want to find a helm chart version that is an exact match 2. If there is a full release version, we want to find a helm chart version that matches the release value but wildcards the patch value (in case we have a patch release) 3. For dev builds, the release version will always be `0.42.42-dev` so this value should be hardcoded as the version. ## Type of change <!-- Please select **one** of the following options that describes your change and delete the others. Clearly identifying the type of change you are making will help us review your PR faster, and is used in authoring release notes. If you are making a bug fix or functionality change to Radius and do not have an associated issue link please create one now. --> - This pull request fixes a bug in Radius and has an approved issue (issue link required). - This pull request adds or changes features of Radius and has an approved issue (issue link required). - This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional). <!-- Please update the following to link the associated issue. This is required for some kinds of changes (see above). --> Fixes: #8195 ## Contributor checklist Please verify that the PR meets the following requirements, where applicable: - [ ] An overview of proposed schema changes is included in a linked GitHub issue. - [ ] A design document PR is created in the [design-notes repository](https://github.com/radius-project/design-notes/), if new APIs are being introduced. - [ ] If applicable, design document has been reviewed and approved by Radius maintainers/approvers. - [ ] A PR for the [samples repository](https://github.com/radius-project/samples) is created, if existing samples are affected by the changes in this PR. - [ ] A PR for the [documentation repository](https://github.com/radius-project/docs) is created, if the changes in this PR affect the documentation or any user facing updates are made. - [ ] A PR for the [recipes repository](https://github.com/radius-project/recipes) is created, if existing recipes are affected by the changes in this PR. --------- Signed-off-by: Vishwanath Hiremath <[email protected]> (cherry picked from commit 5832dea)
vishwahiremat
temporarily deployed
to
functional-tests
GitHub Actions
Inactive
vishwahiremat
temporarily deployed
to
publish-bicep
GitHub Actions
Inactive
sk593
approved these changes
Jan 7, 2025
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/0.42 #8200 +/- ##
================================================
- Coverage 60.09% 60.05% -0.04%
================================================
Files 584 584
Lines 38675 38680 +5
================================================
- Hits 23240 23231 -9
- Misses 13728 13739 +11
- Partials 1707 1710 +3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry picking #8196 into release branch.
Type of change
Fixes: #8195
Contributor checklist
Please verify that the PR meets the following requirements, where applicable:
Signed-off-by: Vishwanath Hiremath [email protected]
(cherry picked from commit 5832dea)
Description
Please explain the changes you've made.
Type of change
Fixes: #issue_number
Contributor checklist
Please verify that the PR meets the following requirements, where applicable: