Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign thread paginator #1607

Merged
merged 3 commits into from
May 23, 2023
Merged

Redesign thread paginator #1607

merged 3 commits into from
May 23, 2023

Conversation

rafalp
Copy link
Owner

@rafalp rafalp commented May 22, 2023

Fixes #1586

Adds new paginator to thread page, that makes users aware of page they are on:

Zrzut ekranu 2023-05-22 o 23 05 32

Also changes thread template so paginator is also displayed on the top, but its only visible when thread has other pages.

Todo:

  • Fix long central button text overflowing whole paginator
  • Add secondary toolbar under first one on thread page with option to go back to top (and maybe go back to category)

@rafalp rafalp added area: frontend This issue involves JavaScript, React.js and Node area: theme This issue involves HTML and CSS labels May 22, 2023
@rafalp rafalp added this to the 0.36 milestone May 22, 2023
@rafalp rafalp self-assigned this May 22, 2023
@coveralls
Copy link

coveralls commented May 22, 2023

Coverage Status

Coverage: 98.441% (+0.0002%) from 98.441% when pulling 7ef2127 on fix-1586-new-thread-paginator into c402855 on main.

@rafalp rafalp merged commit 7c8102c into main May 23, 2023
@rafalp rafalp deleted the fix-1586-new-thread-paginator branch May 23, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: frontend This issue involves JavaScript, React.js and Node area: theme This issue involves HTML and CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Threads paginator redesign
2 participants