Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix underscore in usernames handling #1625

Merged
merged 6 commits into from
May 28, 2023
Merged

Fix underscore in usernames handling #1625

merged 6 commits into from
May 28, 2023

Conversation

rafalp
Copy link
Owner

@rafalp rafalp commented May 27, 2023 •
edited
Loading

Fixes #1623

TODO:

  • Start private thread
  • Add participant to private thread
  • Mention user in post
  • Search for user on forum
  • Search for user in admin
  • JavaScript username validation

Test:

  • Register user
  • Start private thread
  • Add participant to private thread
  • Mention user in post
  • Search for user on forum
  • Search for user in admin
  • JavaScript username validation

@rafalp rafalp added area: frontend This issue involves JavaScript, React.js and Node area: backend This issue involves Python, Django or dependency (eg. database) feature: parser Parser converts markdown/bbcode strings into other forms feature: auth This issue involves auth feature: API RPC or legacy JSON APIs feature: search Searching for content or users labels May 27, 2023
@rafalp rafalp added this to the 0.36.1 milestone May 27, 2023
@rafalp rafalp self-assigned this May 27, 2023
@rafalp rafalp force-pushed the fix-1623-allow-underscore-usernames branch from 3e71865 to f0e8580 Compare May 28, 2023 10:29
@rafalp rafalp changed the title WIP update tests to use username with underscore Fix underscore in usernames handling May 28, 2023
@coveralls
Copy link

coveralls commented May 28, 2023 •
edited
Loading

Coverage Status

Coverage: 98.437% (+0.009%) from 98.428% when pulling 6b8acc2 on fix-1623-allow-underscore-usernames into 9dcfc8f on main.

@rafalp rafalp merged commit 88fbff9 into main May 28, 2023
@rafalp rafalp deleted the fix-1623-allow-underscore-usernames branch May 28, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rafalp rafalp

Labels
area: backend This issue involves Python, Django or dependency (eg. database) area: frontend This issue involves JavaScript, React.js and Node feature: API RPC or legacy JSON APIs feature: auth This issue involves auth feature: parser Parser converts markdown/bbcode strings into other forms feature: search Searching for content or users
Projects
None yet
Milestone
0.36.1
Development

Successfully merging this pull request may close these issues.

Allow underscore in usernames
2 participants
@rafalp @coveralls