Fixes pubkey#830

rafamel · Sep 30, 2018 · 52311c4 · 52311c4
1 parent c1575b7
commit 52311c4
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/src/rx-document.js b/src/rx-document.js
@@ -377,7 +377,7 @@ export const basePrototype = {
      * instead we keep the values and only set _deleted: true
      * @return {Promise<RxDocument>}
      */
-    remove() {
+    async remove() {
         if (this.deleted) {
             throw RxError.newRxError('DOC13', {
                 document: this,

diff --git a/test/unit/rx-document.test.js b/test/unit/rx-document.test.js
@@ -811,5 +811,21 @@ config.parallel('rx-document.test.js', () => {
             // clean up afterwards
             db.destroy();
         });
+        it('#830 RxDocument.remove() rejects -doesn\'t sync throw', async () => {
+            const c = await humansCollection.create(5);
+            const doc = await c.findOne().exec();
+            await doc.remove();
+
+            let asyncE, syncE;
+            try {
+                await doc.remove().catch(e => (asyncE = e));
+            } catch(e) {
+                syncE = e;
+            }
+            assert.equal(syncE, undefined);
+            assert.equal(asyncE instanceof Error, true);
+
+            c.database.destroy();
+        });
     });
 });