Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create sprint-113-summary.md #3434

Merged
merged 3 commits into from
Feb 6, 2025
Merged

Conversation

lhuxraft
Copy link
Collaborator

Internal review has been conducted by @vlasse86. Requesting additional reviews from OFA before merging

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.40%. Comparing base (a655e92) to head (66a4a90).
Report is 3 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3434   +/-   ##
========================================
  Coverage    91.40%   91.40%           
========================================
  Files          302      302           
  Lines         8679     8679           
  Branches       643      643           
========================================
  Hits          7933     7933           
  Misses         625      625           
  Partials       121      121           
Flag Coverage Δ
dev-backend 91.26% <ø> (ø)
dev-frontend 92.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da1bfc9...66a4a90. Read the comment docs.

Copy link
Collaborator

@klinkoberstar klinkoberstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the Blueprint can we mention that keeping it up to date will be an AC for changes that impact the data flow? Since the ticket was "Closed" but we want to keep it as a living document

Otherwise LGTM

Added additional sentence to service blueprint table entry
@lhuxraft
Copy link
Collaborator Author

For the Blueprint can we mention that keeping it up to date will be an AC for changes that impact the data flow? Since the ticket was "Closed" but we want to keep it as a living document

Otherwise LGTM

Great, thanks for the feedback! Added an additional sentence in the table to cover that. Re-requesting review

Copy link
Collaborator

@klinkoberstar klinkoberstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@ADPennington ADPennington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾

@andrew-jameson andrew-jameson merged commit 60e6910 into develop Feb 6, 2025
13 checks passed
@andrew-jameson andrew-jameson deleted the lhuxraft-sprint-113-summary branch February 6, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants