-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create sprint-113-summary.md #3434
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3434 +/- ##
========================================
Coverage 91.40% 91.40%
========================================
Files 302 302
Lines 8679 8679
Branches 643 643
========================================
Hits 7933 7933
Misses 625 625
Partials 121 121
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the Blueprint can we mention that keeping it up to date will be an AC for changes that impact the data flow? Since the ticket was "Closed" but we want to keep it as a living document
Otherwise LGTM
Added additional sentence to service blueprint table entry
Great, thanks for the feedback! Added an additional sentence in the table to cover that. Re-requesting review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏾
Internal review has been conducted by @vlasse86. Requesting additional reviews from OFA before merging