Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/3450 rename gender to sex #3451

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

andrew-jameson
Copy link
Collaborator

Summary of Changes

Provide a brief summary of changes
Pull request closes #3450

How to Test

List the steps to test the PR
These steps are generic, please adjust as necessary.

cd tdrs-frontend && docker-compose up --build
cd tdrs-backend && docker-compose up --build
  1. Open http://localhost:3000/ and sign in.
  2. Proceed with functional tests as described herein.
  3. Test steps should be captured in the demo GIF(s) and/or screenshots below.

Demo GIF(s) and screenshots for testing procedure

Deliverables

More details on how deliverables herein are assessed included here.

Deliverable 1: Accepted Features

Checklist of ACs:

  • [insert ACs here]
  • lfrohlich and/or adpennington confirmed that ACs are met.

Deliverable 2: Tested Code

  • Are all areas of code introduced in this PR meaningfully tested?
    • If this PR introduces backend code changes, are they meaningfully tested?
    • If this PR introduces frontend code changes, are they meaningfully tested?
  • Are code coverage minimums met?
    • Frontend coverage: [insert coverage %] (see CodeCov Report comment in PR)
    • Backend coverage: [insert coverage %] (see CodeCov Report comment in PR)

Deliverable 3: Properly Styled Code

  • Are backend code style checks passing on CircleCI?
  • Are frontend code style checks passing on CircleCI?
  • Are code maintainability principles being followed?

Deliverable 4: Accessible

  • Does this PR complete the epic?
  • Are links included to any other gov-approved PRs associated with epic?
  • Does PR include documentation for Raft's a11y review?
  • Did automated and manual testing with iamjolly and ttran-hub using Accessibility Insights reveal any errors introduced in this PR?

Deliverable 5: Deployed

  • Was the code successfully deployed via automated CircleCI process to development on Cloud.gov?

Deliverable 6: Documented

  • Does this PR provide background for why coding decisions were made?
  • If this PR introduces backend code, is that code easy to understand and sufficiently documented, both inline and overall?
  • If this PR introduces frontend code, is that code easy to understand and sufficiently documented, both inline and overall?
  • If this PR introduces dependencies, are their licenses documented?
  • Can reviewer explain and take ownership of these elements presented in this code review?

Deliverable 7: Secure

  • Does the OWASP Scan pass on CircleCI?
  • Do manual code review and manual testing detect any new security issues?
  • If new issues detected, is investigation and/or remediation plan documented?

Deliverable 8: User Research

Research product(s) clearly articulate(s):

  • the purpose of the research
  • methods used to conduct the research
  • who participated in the research
  • what was tested and how
  • impact of research on TDP
  • (if applicable) final design mockups produced for TDP development

@andrew-jameson andrew-jameson self-assigned this Jan 31, 2025
@andrew-jameson andrew-jameson marked this pull request as ready for review January 31, 2025 20:51
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.43%. Comparing base (e67e58a) to head (0e95366).
Report is 4 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3451   +/-   ##
========================================
  Coverage    91.43%   91.43%           
========================================
  Files          300      301    +1     
  Lines         8647     8651    +4     
  Branches       640      640           
========================================
+ Hits          7906     7910    +4     
  Misses         621      621           
  Partials       120      120           
Flag Coverage Δ
dev-backend 91.29% <100.00%> (+<0.01%) ⬆️
dev-frontend 92.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...s-backend/tdpservice/parsers/schema_defs/ssp/m2.py 100.00% <ø> (ø)
...s-backend/tdpservice/parsers/schema_defs/ssp/m3.py 100.00% <ø> (ø)
...s-backend/tdpservice/parsers/schema_defs/ssp/m5.py 100.00% <ø> (ø)
...-backend/tdpservice/parsers/schema_defs/tanf/t2.py 100.00% <ø> (ø)
...-backend/tdpservice/parsers/schema_defs/tanf/t3.py 100.00% <ø> (ø)
...-backend/tdpservice/parsers/schema_defs/tanf/t5.py 100.00% <ø> (ø)
...d/tdpservice/parsers/schema_defs/tribal_tanf/t2.py 100.00% <ø> (ø)
...d/tdpservice/parsers/schema_defs/tribal_tanf/t3.py 100.00% <ø> (ø)
...d/tdpservice/parsers/schema_defs/tribal_tanf/t5.py 100.00% <ø> (ø)
tdrs-backend/tdpservice/parsers/test/factories.py 100.00% <100.00%> (ø)
... and 7 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90e2823...0e95366. Read the comment docs.

@andrew-jameson
Copy link
Collaborator Author

@klinkoberstar Happy to cut a release and send it over to Alex Monday to coordinate that for the deadline on Friday February 7th.

]

operations = [
migrations.RenameField(
Copy link

@jtimpe jtimpe Jan 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any idea how RenameField will end up actually getting applied to the db? I'd assume it doesn't update every record, but the table as a whole. Just want to make sure we don't end up with another big migration headache

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👆🏾good q!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any idea how RenameField will end up actually getting applied to the db? I'd assume it doesn't update every record, but the table as a whole. Just want to make sure we don't end up with another big migration headache

That was my understanding, it's a column/field name change.

@andrew-jameson andrew-jameson requested a review from jtimpe February 3, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename GENDER to SEX per Executive Order
5 participants