-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix/3450 rename gender to sex #3451
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3451 +/- ##
========================================
Coverage 91.43% 91.43%
========================================
Files 300 301 +1
Lines 8647 8651 +4
Branches 640 640
========================================
+ Hits 7906 7910 +4
Misses 621 621
Partials 120 120
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
@klinkoberstar Happy to cut a release and send it over to Alex Monday to coordinate that for the deadline on Friday February 7th. |
] | ||
|
||
operations = [ | ||
migrations.RenameField( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any idea how RenameField
will end up actually getting applied to the db? I'd assume it doesn't update every record, but the table as a whole. Just want to make sure we don't end up with another big migration headache
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👆🏾good q!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any idea how
RenameField
will end up actually getting applied to the db? I'd assume it doesn't update every record, but the table as a whole. Just want to make sure we don't end up with another big migration headache
That was my understanding, it's a column/field name change.
Summary of Changes
Provide a brief summary of changes
Pull request closes #3450
How to Test
List the steps to test the PR
These steps are generic, please adjust as necessary.
Deliverables
More details on how deliverables herein are assessed included here.
Deliverable 1: Accepted Features
Checklist of ACs:
lfrohlich
and/oradpennington
confirmed that ACs are met.Deliverable 2: Tested Code
CodeCov Report
comment in PR)CodeCov Report
comment in PR)Deliverable 3: Properly Styled Code
Deliverable 4: Accessible
iamjolly
andttran-hub
using Accessibility Insights reveal any errors introduced in this PR?Deliverable 5: Deployed
Deliverable 6: Documented
Deliverable 7: Secure
Deliverable 8: User Research
Research product(s) clearly articulate(s):