Front/119/reports #461
Merged
Front/119/reports #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for upload reducer
…to front/119/reports
alexsoble
reviewed
Dec 11, 2020
|
|
||
| /** | ||
| * | ||
| * @param {string} pathname - The full current url path. |
alexsoble
reviewed
Dec 11, 2020
| import { setYear } from '../../actions/upload' | ||
|
|
||
| /** | ||
| * @param {string} selectedYear = The year that the user has chosen from the |
alexsoble
reviewed
Dec 11, 2020
| <li className="usa-nav__primary-item"> | ||
| <a | ||
| href={href} | ||
| key="welcome" |
There was a problem hiding this comment.
@hilvitzs I think the key should be unique: https://reactjs.org/docs/lists-and-keys.html
|
👍 on internal a11y checks |
hilvitzs
force-pushed
the
front/119/reports
branch
from
c871832 to
932c532
Compare
carltonsmith
approved these changes
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes...
This adds the initial reports page which should match the mock below.
There should be a route for
Reportswith a corresponding navigation tab that is highlighted when on any variation of/reports/*.There should be a page title of 'TANF Reports' and the browser tab should display that name
There should be a
Selectdropdown that allows the user to select either the year2020or2021for the ATO. When you make a selection it should update theptag underneath the select with the selected year.The label for the
Selectdropdown should read "Fiscal Year (October - September)"There should be a button to
Begin Reportand upon click of this button the user should be routed to `/reports/[the user's selected year]/upload'. There won't be anything on that page yet but that work will be completed in #429 .This addresses issue #119
TO TEST
List the steps to test the PR
Log in to the application and you will be directed to
/edit-profile.There should be a navigation tab that reads
Reports- click on that and you should be rerouted to/reportswhere you will see the new page.You should be able to choose between 2020 and 2021. When you have chosen the year, it should update the
ptag below with the selected year. When you have made a selection, click onBegin Reportand you should be rerouted to/reports/[the year you selected]/upload.This pull request is ready to merge when...