Release ActiveRecord connections on yield #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this improves performance in the case when an application sends a query to the DB (for instance, to check the validity of an API token) and then sends an HTTP request. Without this change the AR connection would hang unavailable for other fibers until the HTTP request is finished.
rsamoilov
added a commit
that referenced
this pull request
Apr 28, 2024
something has changed in AR 7.1, and releasing the connections on yield doesn't work reliably anymore. At the moment, I've got neither time nor motivation to look into what's happened there, and as much as I'm not happy about it, currently, the solution is to disable this behaviour for AR 7.1+. ref: #66
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this improves performance in the case when an application sends a query to the DB (for instance, to check the validity of an API token) and then sends an HTTP request. Without this change the AR connection would hang unavailable for other fibers until the HTTP request is finished.