Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gas estimates for the ServiceRegistry #1122

Closed
2 tasks done
palango opened this issue Jul 12, 2019 · 2 comments
Closed
2 tasks done

Add gas estimates for the ServiceRegistry #1122

palango opened this issue Jul 12, 2019 · 2 comments
Assignees
@pirapira
Labels
efforts: low_hanging_fruit P1 urgent, blocker, or makes life easier forever

Comments

@palango
Copy link
Contributor

palango commented Jul 12, 2019 •
edited by pirapira
Loading

Currently there are no gas estimates for the service registry available. They should be added for

  • deposit
  • setURL
@pirapira pirapira added P1 urgent, blocker, or makes life easier forever efforts: low_hanging_fruit labels Jul 12, 2019
@pirapira pirapira self-assigned this Jul 12, 2019
pirapira added a commit to pirapira/raiden-contracts that referenced this issue Jul 12, 2019
@pirapira
Add gas measurements for
2db1394 
ServiceRegistry.deposit() and ServiceRegistry.setURL().

This is a part of raiden-network#1122.
@pirapira
Copy link
Contributor

I added these measurements (deposit and setURL) in #1116.

pirapira added a commit to pirapira/raiden-contracts that referenced this issue Jul 12, 2019
@pirapira
Add gas measurements for
8182ef4 
ServiceRegistry.deposit() and ServiceRegistry.setURL().

This is a part of raiden-network#1122.
pirapira added a commit to pirapira/raiden-contracts that referenced this issue Jul 15, 2019
@pirapira
Add gas measurements for
2a6831d 
ServiceRegistry.deposit() and ServiceRegistry.setURL().

This is a part of raiden-network#1122.
pirapira added a commit to pirapira/raiden-contracts that referenced this issue Jul 15, 2019
@pirapira
Add gas measurements for
0ccb9f1 
ServiceRegistry.deposit() and ServiceRegistry.setURL().

This is a part of raiden-network#1122.
pirapira added a commit to pirapira/raiden-contracts that referenced this issue Jul 15, 2019
@pirapira
Add gas measurements for
d6036d5 
ServiceRegistry.deposit() and ServiceRegistry.setURL().

This is a part of raiden-network#1122.
pirapira added a commit that referenced this issue Jul 16, 2019
@pirapira
Add gas measurements for
38b01d0 
ServiceRegistry.deposit() and ServiceRegistry.setURL().

This is a part of #1122.
@pirapira
Copy link
Contributor

These have been added on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pirapira pirapira

Labels
efforts: low_hanging_fruit P1 urgent, blocker, or makes life easier forever
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pirapira @palango