Withdraw expires #1103
Merged
Withdraw expires #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Especially, calling setTotalWithdraw() with zero, the current block number, or one bigger as the expiration block number.
Codecov Report
@@ Coverage Diff @@
## master #1103 +/- ##
=======================================
Coverage 80.75% 80.75%
=======================================
Files 20 20
Lines 1382 1382
Branches 174 174
=======================================
Hits 1116 1116
Misses 227 227
Partials 39 39
Continue to review full report at Codecov.
|
|
Yay! |
|
I'll make a |
Merged
pirapira
added a commit
to pirapira/spec
that referenced
this pull request
Sep 5, 2019
This commit adds the new argument `expiration_block` to `setTotalWithdraw()` function. The change follows the implementation raiden-network/raiden-contracts#1103 This commit is a part of updating the spec raiden-network#253
pirapira
added a commit
to pirapira/spec
that referenced
this pull request
Sep 5, 2019
This commit adds the new argument `expiration_block` to `setTotalWithdraw()` function. The change follows the implementation raiden-network/raiden-contracts#1103 This commit is a part of updating the spec raiden-network#253
palango
pushed a commit
to raiden-network/spec
that referenced
this pull request
Sep 6, 2019
This commit adds the new argument `expiration_block` to `setTotalWithdraw()` function. The change follows the implementation raiden-network/raiden-contracts#1103 This commit is a part of updating the spec #253
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an argument
expiration_blocktoTokenNetwork.setTotalWithdraw().This closes #1102.