Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OneToN contract no longer works with unregistered services #1151

Merged
merged 11 commits into from
Aug 15, 2019
Merged

OneToN contract no longer works with unregistered services #1151

merged 11 commits into from
Aug 15, 2019

Conversation

pirapira
Copy link
Contributor

This is a part of #1147.

@codecov
Copy link

codecov bot commented Jul 30, 2019 •
edited
Loading

Codecov Report

Merging #1151 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1151      +/-   ##
==========================================
+ Coverage   81.11%   81.14%   +0.02%     
==========================================
  Files          21       21              
  Lines        1451     1453       +2     
  Branches      190      191       +1     
==========================================
+ Hits         1177     1179       +2     
  Misses        231      231              
  Partials       43       43
Impacted Files Coverage Δ
raiden_contracts/deploy/contract_verifier.py 85.71% <100%> (+0.18%) ⬆️
raiden_contracts/deploy/contract_deployer.py 90% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 429da97...40eee07. Read the comment docs.

@pirapira pirapira requested a review from palango August 13, 2019 07:22
@pirapira pirapira changed the title OneToN contract doesn't work with unregistered services OneToN contract no longer works with unregistered services Aug 13, 2019
palango
palango reviewed Aug 13, 2019
View reviewed changes
Copy link
Contributor

@palango palango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid in general. Left some comments.

CHANGELOG.md Outdated Show resolved Hide resolved
raiden_contracts/tests/test_one_to_n.py Outdated Show resolved Hide resolved
raiden_contracts/tests/test_one_to_n.py Show resolved Hide resolved
raiden_contracts/tests/test_print_gas.py Outdated Show resolved Hide resolved
@pirapira pirapira force-pushed the one-to-n-unregistered-services branch 2 times, most recently from 9953700 to 14d90d8 Compare August 13, 2019 15:09
@pirapira pirapira force-pushed the one-to-n-unregistered-services branch from 14d90d8 to 83cab44 Compare August 15, 2019 10:33
@pirapira pirapira force-pushed the one-to-n-unregistered-services branch from b62ac28 to 40eee07 Compare August 15, 2019 12:27
palango
palango approved these changes Aug 15, 2019
View reviewed changes
Copy link
Contributor

@palango palango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes, this is ready to roll!

@pirapira pirapira merged commit d9d4875 into raiden-network:master Aug 15, 2019
@pirapira pirapira deleted the one-to-n-unregistered-services branch August 15, 2019 12:52
@pirapira pirapira mentioned this pull request Sep 3, 2019
Closed
@pirapira pirapira mentioned this pull request Sep 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palango palango palango approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pirapira @palango