-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fields to NewBalanceProofReceived event #373
Conversation
as suggested in raiden-network#360 (comment) .
`raiden_libs.utils.signing.eth_sign` includes the "\x19Ethereum Signed Message" prefix while `raiden_contracts.utils.sign_utils.sign` doesn’t. @pirapira suggested that including the prefix is usually a good idea because some clients can only create signatures including it. We might want to add these inside the sign and verify functions, but let's make the behaviour consistent first and the refactor, if we really want the prefix in all cases.
Avoids duplication of message prefix.
as suggested in raiden-network#360 (comment) .
Some notes:
|
Yes, good idea. My current focus is to get the MS working again, at all. I've just kept the events and parameters without checking the reason for their existence. I'll do so, but it's not something I'll do right now. |
Events are an important part of the SC functionality, so they should be tested! Requested in raiden-network#373 (comment).
Done in f5d81a4. |
raiden_contracts/constants.py
Outdated
@@ -92,6 +92,14 @@ class MessageTypeId(IntEnum): | |||
COOPERATIVE_SETTLE = 4 | |||
|
|||
|
|||
# Message types used my MonitoringService contract |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/s/my/by
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
I would like to keep the logic separate for core and services -> different files & folders for tests, constants & fixtures, but this can be discussed separately.
Please fix the conflict on contracts.json
and we can merge this.
as suggested in
#360 (comment) .