Basic OneToN payment implentation. #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also provide an initialized UDC from the default `user_deposit_contract` fixture. Only the UDC tests need an uninitialized UDC. This might allow reusing the same UDC across multiple tests to speed up the tests. But I still have to work out the details for that to be sure.
pirapira
reviewed
Jan 31, 2019
| NEW_BALANCE_PROOF_RECEIVED = 'NewBalanceProofReceived' | ||
| REWARD_CLAIMED = 'RewardClaimed' | ||
| WITHDRAWN = 'Withdrawn' |
There was a problem hiding this comment.
I missed these last time.
pirapira
reviewed
Jan 31, 2019
| require(addressFromSignature == sender); | ||
|
|
||
| // must not be claimed before | ||
| bytes32 _key = keccak256(abi.encodePacked(receiver, sender, expiration_block)); |
There was a problem hiding this comment.
Why is _key prefixed with an underscore? (Pure curiosity.)
There was a problem hiding this comment.
Heiko did that when sketching his idea and I thought it might be a keyword and left it that way. But looking it up, it's not one of the reserved keywords: https://solidity.readthedocs.io/en/v0.4.21/miscellaneous.html#reserved-keywords . So the "key" word is not a keyword.
pirapira
added this to the Ithaca: (0.10.0) RSB contracts deployment on test nets (Feb 15, 2019) milestone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First implementation of the contract for PFS payments described in raiden-network/raiden-services#38. Another function to reduce gas usage by claiming multiple IOUs at once and freeing old storage slots will follow.