Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove flavors Part 1 #647

Merged
merged 5 commits into from
Mar 1, 2019
Merged

Remove flavors Part 1 #647

merged 5 commits into from
Mar 1, 2019

Conversation

pirapira
Copy link
Contributor

@pirapira pirapira commented Mar 1, 2019

This PR removes

  • the unlimited flavor, and
  • the mustache template mechanism.

@pirapira pirapira added P1 urgent, blocker, or makes life easier forever dev: Please Review labels Mar 1, 2019
This was referenced Mar 1, 2019
Closed
Merged
@pirapira pirapira requested a review from kelsos March 1, 2019 15:34
@pirapira pirapira mentioned this pull request Mar 1, 2019
Merged
kelsos
kelsos approved these changes Mar 1, 2019
View reviewed changes
Copy link

@kelsos kelsos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pirapira pirapira merged commit c6d58e9 into raiden-network:master Mar 1, 2019
@pirapira pirapira deleted the remove-flavors branch March 1, 2019 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelsos kelsos kelsos approved these changes

Assignees
No one assigned
Labels
P1 urgent, blocker, or makes life easier forever
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pirapira @kelsos