-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a whole balance limit to UserDeposit #678
Conversation
c6b0536
to
7b345ce
Compare
I'm not sure which requirements we have for the choice of our limits. Having a per-account limit would be simpler and more gas efficient than having a global limit. But I assume you know that and did it this way for a good reason. |
@karlb the reason for the total limit can be seen here: https://github.com/raiden-network/team/issues/333 In general, one person can create an unlimited number of Ethereum accounts, so usually per-account limitations are not very effective. |
which is configurable at the deployment time. Currently we keep the option of limiting deposits in all smart contracts.
7b345ce
to
b596f66
Compare
Codecov Report
@@ Coverage Diff @@
## master #678 +/- ##
=======================================
Coverage 20.29% 20.29%
=======================================
Files 16 16
Lines 1069 1069
Branches 118 118
=======================================
Hits 217 217
Misses 850 850
Partials 2 2 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #678 +/- ##
===========================================
+ Coverage 20.29% 64.79% +44.49%
===========================================
Files 16 17 +1
Lines 1069 1122 +53
Branches 118 119 +1
===========================================
+ Hits 217 727 +510
+ Misses 850 369 -481
- Partials 2 26 +24
Continue to review full report at Codecov.
|
which is configurable at the deployment time.
Currently we keep the option of limiting deposits in all smart contracts (https://github.com/raiden-network/team/issues/324#issuecomment-465100567).
I chose against using the contract's token balance because that poses a DOS attack possibility.
This closes #585.