ServiceRegistry() takes a token what token #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a token for registration fees. This closes raiden-network#735
LefterisJP
reviewed
Mar 13, 2019
|
|
||
| token = Token(_token_address); |
There was a problem hiding this comment.
Why is the code duplicated? Both here and in raiden_contracts/contracts/services/ServiceRegistry.sol ?
There was a problem hiding this comment.
Just for historical reasons. I guess make compile_contracts and others should just look at data/source/..., and the duplication can be removed.
There was a problem hiding this comment.
Yes please let's do that, maintaining duplicated contract code sounds like a nightmare.
LefterisJP
approved these changes
Mar 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a token for registration fees.
This closes #735