Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the keyword argument's key #941

Merged
merged 1 commit into from
May 6, 2019
Merged

Fix the keyword argument's key #941

merged 1 commit into from
May 6, 2019

Conversation

pirapira
Copy link
Contributor

@pirapira pirapira commented May 6, 2019

This closes #927.

@pirapira
Copy link
Contributor Author

pirapira commented May 6, 2019

I'm expecting some CodeCov failures, so I'll add tests.

@codecov
Copy link

codecov bot commented May 6, 2019 •
edited
Loading

Codecov Report

Merging #941 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #941   +/-   ##
=======================================
  Coverage   87.24%   87.24%           
=======================================
  Files          20       20           
  Lines        1278     1278           
  Branches      149      149           
=======================================
  Hits         1115     1115           
  Misses        130      130           
  Partials       33       33
Impacted Files Coverage Δ
raiden_contracts/deploy/__main__.py 81.5% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de13ff7...2572fce. Read the comment docs.

@pirapira
Copy link
Contributor Author

pirapira commented May 6, 2019

The patch hit is 100%. Weird.

@pirapira pirapira requested a review from rakanalh May 6, 2019 14:57
@rakanalh rakanalh merged commit 3b2d583 into raiden-network:master May 6, 2019
@pirapira pirapira deleted the key branch May 6, 2019 21:37
@pirapira pirapira mentioned this pull request Sep 3, 2019
Closed
@pirapira pirapira mentioned this pull request Sep 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rakanalh rakanalh rakanalh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError in deploy/__main.py
2 participants
@pirapira @rakanalh