Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send_async / _handle_invite race #3588

Closed
err508 opened this issue Mar 6, 2019 · 2 comments
Closed

send_async / _handle_invite race #3588

err508 opened this issue Mar 6, 2019 · 2 comments
Assignees
Labels
Component / Transport Transport related issues

Comments

@err508
Copy link
Contributor

err508 commented Mar 6, 2019

Problem Definition

There is a race condition with send_async / _handle_invite. Triggered if:

  • Client A invites
  • The invite triggers _handle_invite in Client B's transport
  • Client A starts sending messages to Client B
  • Messages are lost, as the invite was not processed yet

Appeared during #3124 as seen here, related #2779, #3123.

@err508 err508 self-assigned this Mar 6, 2019
@err508 err508 added the Component / Transport Transport related issues label Mar 6, 2019
@andrevmatos
Copy link
Contributor

This is expected. Retry logic should handle this. How this was not the case?

@err508
Copy link
Contributor Author

err508 commented Mar 6, 2019

_handle_invite is (timewise) expensive for private rooms, the send_async retries go through before _handle_invite is completed.

@err508 err508 mentioned this issue Mar 7, 2019
err508 pushed a commit that referenced this issue Mar 14, 2019
err508 pushed a commit that referenced this issue Mar 14, 2019
err508 pushed a commit that referenced this issue Mar 14, 2019
err508 pushed a commit that referenced this issue Mar 15, 2019
err508 pushed a commit that referenced this issue Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component / Transport Transport related issues
Projects
None yet
Development

No branches or pull requests

2 participants