Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MatrixTransport.send_global method #3436

Merged
merged 4 commits into from
Feb 8, 2019
Merged

MatrixTransport.send_global method #3436

merged 4 commits into from
Feb 8, 2019

Conversation

andrevmatos
Copy link
Contributor

Method to send messages to one of the configured global rooms.
Needed for #3273 , based on top of #3427 so should be merged after it.

@codecov
Copy link

codecov bot commented Feb 7, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@1d90895). Click here to learn what that means.
The diff coverage is 84.21%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3436   +/-   ##
=========================================
  Coverage          ?   76.03%           
=========================================
  Files             ?      100           
  Lines             ?    12973           
  Branches          ?     1825           
=========================================
  Hits              ?     9864           
  Misses            ?     2464           
  Partials          ?      645
Impacted Files Coverage Δ
raiden/network/transport/matrix/__init__.py 100% <ø> (ø)
raiden/network/transport/udp/udp_transport.py 89.95% <50%> (ø)
raiden/network/transport/matrix/transport.py 75.16% <82.6%> (ø)
raiden/network/transport/matrix/utils.py 75.83% <87.5%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d90895...2cf3092. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 7, 2019

Codecov Report

Merging #3436 into master will increase coverage by 0.05%.
The diff coverage is 92.3%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3436      +/-   ##
==========================================
+ Coverage   76.22%   76.27%   +0.05%     
==========================================
  Files         101      101              
  Lines       13129    13142      +13     
  Branches     1837     1838       +1     
==========================================
+ Hits        10007    10024      +17     
- Misses       2469     2470       +1     
+ Partials      653      648       -5
Impacted Files Coverage Δ
raiden/network/transport/matrix/transport.py 75.48% <100%> (+1.74%) ⬆️
raiden/network/transport/udp/udp_transport.py 89.95% <50%> (-1.14%) ⬇️
raiden/utils/__init__.py 67.44% <0%> (-4.66%) ⬇️
raiden/network/proxies/token_network.py 80.76% <0%> (-0.64%) ⬇️
raiden/messages.py 88.74% <0%> (-0.17%) ⬇️
raiden/transfer/events.py 74% <0%> (+0.4%) ⬆️
raiden/tasks.py 74.8% <0%> (+0.78%) ⬆️
raiden/transfer/mediated_transfer/events.py 84.11% <0%> (+0.93%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b383ce...e741a7a. Read the comment docs.

Copy link
Contributor

@rakanalh rakanalh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also looks good with some minor comments.

I am also missing where the integration between the new monitoring-specific messages and send_global is done. I am assuming that's going to be in a follow up PR, right?

raiden/network/transport/udp/udp_transport.py Outdated Show resolved Hide resolved
UDP is noop, Matrix requires one of the global room suffixes passed in
config['global_rooms'] list and a message.
Copy link
Collaborator

@ulope ulope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two nitpicks. Otherwise LGTM.

raiden/network/transport/matrix/transport.py Outdated Show resolved Hide resolved
raiden/network/transport/matrix/transport.py Outdated Show resolved Hide resolved
@andrevmatos andrevmatos merged commit 13c969f into raiden-network:master Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants