-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MatrixTransport.send_global method #3436
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3436 +/- ##
=========================================
Coverage ? 76.03%
=========================================
Files ? 100
Lines ? 12973
Branches ? 1825
=========================================
Hits ? 9864
Misses ? 2464
Partials ? 645
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #3436 +/- ##
==========================================
+ Coverage 76.22% 76.27% +0.05%
==========================================
Files 101 101
Lines 13129 13142 +13
Branches 1837 1838 +1
==========================================
+ Hits 10007 10024 +17
- Misses 2469 2470 +1
+ Partials 653 648 -5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also looks good with some minor comments.
I am also missing where the integration between the new monitoring-specific messages and send_global
is done. I am assuming that's going to be in a follow up PR, right?
UDP is noop, Matrix requires one of the global room suffixes passed in config['global_rooms'] list and a message.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two nitpicks. Otherwise LGTM.
Method to send messages to one of the configured global rooms.
Needed for #3273 , based on top of #3427 so should be merged after it.