Switch to Synapse >= 1.0 #4646
Merged
Switch to Synapse >= 1.0 #4646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #4646 +/- ##
===========================================
- Coverage 80.71% 80.68% -0.04%
===========================================
Files 120 120
Lines 14597 14605 +8
Branches 2262 2263 +1
===========================================
+ Hits 11782 11784 +2
- Misses 2151 2158 +7
+ Partials 664 663 -1
Continue to review full report at Codecov.
|
|
@ulope I think this PR is the right place to remove the cache hack https://github.com/raiden-network/raiden/pull/4665/files#diff-1d37e48f9ceff6d8030570cd36286a61R183 we introduced. |
(Not mergable currently because of raiden-network#4634. Temporarily uses the base64 solution mentioned in the issue.) This updates our testing dependency to matrix-synapse 1.2.1. The Synapse config files generated by the integration tests have been updated to align with new / changed options. Additionally this no longer uses local TLS certificates speeding up tests. Fixes: raiden-network#3387 Required for: raiden-network#4292
ulope
force-pushed
the
feature/synapse-1.x
branch
from
4633a64 to
acfb515
Compare
LefterisJP
reviewed
Oct 1, 2019
| recovered = recover( | ||
| data=user.user_id.encode(), signature=Signature(decode_hex(displayname)) | ||
| ) | ||
| if DISPLAY_NAME_HEX_RE.match(displayname): |
There was a problem hiding this comment.
Is this new if check covered by any unit test?
There was a problem hiding this comment.
Yes, invalid signatures are already being tested for. This is just an optimization to skip ecrecover on obviously invalid values.
LefterisJP
approved these changes
Oct 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Not mergable currently because of #4634. Temporarily uses the base64 solution mentioned in the issue.)
This updates our testing dependency to matrix-synapse 1.2.1.
The Synapse config files generated by the integration tests have been updated to align with new / changed options.
Additionally this no longer uses local TLS certificates speeding up tests.
Fixes: #3387
Required for: #4292
Blocked by: #4634