Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.8.21 is now the lowest geth supported #4983

Merged

Conversation

LefterisJP
Copy link
Contributor

Description

Set 1.8.21 to lowest supported geth version

This is to have the eth_getTransactionCount fix: ethereum/go-ethereum#2880

PR review check list

Quality check list that cannot be automatically verified.

  • Safety
  • Code quality
    • Error conditions are handled
    • Exceptions are propagated to the correct parent greenlet
    • Exceptions are correctly classified as recoverable or unrecoverable
  • Compatibility
    • State changes are forward compatible
    • Transport messages are backwards and forward compatible
  • Commits
    • Have good messages
    • Squashed unecessary commits
  • If it's a bug fix:
    • Regression test for the bug
      • Properly covers the bug
      • If an integration test is used, it could not be written as a unit test
  • Documentation
    • A new CLI flag was introduced, is there documentation that explains usage?
  • Specs
    • If this is a protocol change, are the specs updated accordingly? If so, please link PR from the specs repo.
  • Is it a user facing feature/bug fix?
    • Changelog entry has been added

@auto-assign auto-assign bot requested a review from hackaugusto September 25, 2019 14:27
Copy link
Contributor

@palango palango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'd also state this in the changelog.

@codecov
Copy link

codecov bot commented Sep 25, 2019

Codecov Report

Merging #4983 into develop will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #4983      +/-   ##
==========================================
- Coverage    80.62%   80.6%   -0.02%     
==========================================
  Files          120     120              
  Lines        14595   14595              
  Branches      2262    2262              
==========================================
- Hits         11767   11765       -2     
- Misses        2157    2158       +1     
- Partials       671     672       +1
Impacted Files Coverage Δ
raiden/constants.py 100% <100%> (ø) ⬆️
raiden/network/transport/matrix/transport.py 80.03% <0%> (-0.92%) ⬇️
raiden/network/proxies/token_network.py 50.18% <0%> (-0.74%) ⬇️
raiden/api/python.py 68.33% <0%> (-0.53%) ⬇️
raiden/network/transport/matrix/client.py 69.8% <0%> (+1.29%) ⬆️
raiden/utils/echo_node.py 69.49% <0%> (+1.69%) ⬆️
raiden/tasks.py 70.07% <0%> (+2.18%) ⬆️
raiden/storage/serialization/types.py 64.17% <0%> (+4.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abc8c00...2fc6ccc. Read the comment docs.

@LefterisJP
Copy link
Contributor Author

Looks good. I'd also state this in the changelog.

good point

@LefterisJP LefterisJP merged commit f40adc8 into raiden-network:develop Sep 25, 2019
@LefterisJP LefterisJP deleted the 1_8_21_lowest_geth_supported branch September 25, 2019 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eth_getTransactionCount does not include pending transactions when 'pending' qualifier given
3 participants