Fix a whole bunch of deprecation warnings #6887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulope
force-pushed
the
fix/deprecations-2021.03
branch
from
fa7ec01 to
f03aed0
Compare
ulope
force-pushed
the
fix/deprecations-2021.03
branch
from
f03aed0 to
309a096
Compare
|
The broken tests look like they are caused by upgrading semantic-version. |
karlb
approved these changes
Mar 18, 2021
| @@ -12,6 +12,7 @@ Flask-Cors | |||
| Flask-RESTful | |||
| gevent>=1.5a3 | |||
| guppy3 | |||
| jinja2>=2.11 | |||
There was a problem hiding this comment.
I'm not sure why we need this explicitly.
There was a problem hiding this comment.
Because versions before that used old deprecated collections imports (ABC base classes) which will break starting with Python 3.9.
github-actions
bot
added
the
State / Blocked
We had accrued a big bunch of deprecation warnings (which usually showed up when running the tests) which would cause breakage in future Python versions. This upgrades packages as necessary and fixes most warnings. The remaining ones are being tracked here: - raiden-network/raiden-api-client#1 - matrix-org/synapse#9641 - matrix-org/synapse#9642 - slezica/python-frozendict#25 This also temporarily removes the docs requirements from the dev set since there's a conflict between `releases` and `py-solc-x` pinned versions of `semantic-version`. See: bitprophet/releases#94
ulope
force-pushed
the
fix/deprecations-2021.03
branch
from
309a096 to
8af9854
Compare
github-actions
bot
removed
the
State / Blocked
|
🎉 Great news! Looks like all the dependencies have been resolved: 💡 To add or remove a dependency please update this issue/PR description. Brought to you by Dependent Issues (:robot: ). Happy coding! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We had accrued a big bunch of deprecation warnings (which usually showed up when running the tests) which would cause reakage in future Python versions.
This upgrades packages as necessary and fixes most warnings.
The remaining ones are being tracked here:
This also temporarily removes the docs requirements from the dev set since there's a conflict between
releasesandpy-solc-xpinned versions ofsemantic-version. See: bitprophet/releases#94This requires some fixes in raiden-contracts.
Requires raiden-network/raiden-contracts#1443