Add OneToN spec #205
Merged
Add OneToN spec #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is raiden-network/raiden-services#38 with only few changes. Spefic functions will be documented as the implemenation makes progress.
palango
reviewed
Jan 29, 2019
| ------------------------------------ | ||
|
|
||
| When requesting a route, the IOU is added as five separate arguments to | ||
| the `existing HTTP query params`_. |
There was a problem hiding this comment.
I though it would go in the request header as it's done in uRaiden!? Does this bring advantages?
There was a problem hiding this comment.
Our spec does not say how REST params are passed in other places (GET or POST). We should add that.
And we should pass these the same way for simplicity unless there's a reason to do it differently.
There was a problem hiding this comment.
In this case GET is not a good idea, since we expect different results and different payment info each time.
There was a problem hiding this comment.
Ok, so we need to look into that anyways.
palango
approved these changes
Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is raiden-network/raiden-services#38 with
only few changes. Spefic functions will be documented as the
implemenation makes progress.