#70 Memoize iframe url to avoid unexpected reload

railmapgen · Apr 28, 2024 · ca317cb · ca317cb
1 parent 6d43883
commit ca317cb
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/src/components/workspace/app-container.tsx b/src/components/workspace/app-container.tsx
@@ -1,4 +1,4 @@
-import { useState } from 'react';
+import { useMemo } from 'react';
 import { FRAME_ID_PREFIX, WorkspaceTab } from '../../util/constants';
 import { Box } from '@chakra-ui/react';
 
@@ -10,9 +10,7 @@ interface AppContainerProps {
 export default function AppContainer(props: AppContainerProps) {
     const { tab, isActive } = props;
 
-    const [frameUrl] = useState(tab.url ?? '/' + tab.app + '/');
-
-    // setFrameUrl if tab.id is updated?
+    const frameUrl = useMemo(() => tab.url ?? '/' + tab.app + '/', [tab.url, tab.app]);
 
     return (
         <Box display={isActive ? 'block' : 'none'} flex={1}>