Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rescue_from handler fails with AMS #917

Closed
ryansch opened this issue May 19, 2015 · 1 comment · Fixed by #918
Closed

rescue_from handler fails with AMS #917

ryansch opened this issue May 19, 2015 · 1 comment · Fixed by #918
Labels
S: Needs Bug Verification V: 0.10.x

Comments

@ryansch
Copy link
Contributor

ryansch commented May 19, 2015

ActionController::Serialization caches the serializer discovered in #get_serializer in @_serializer. When the render call raises an error and ends up in a rescue_from handler, the serializer is still set to whatever was discovered before the error was raised. This usually prevents the correct error response from being generated.
ryansch added a commit to outstand/active_model_serializers that referenced this issue May 20, 2015
@ryansch
Add rescue_from handler to clear state
9355416 
Fixes rails-api#917
@ryansch ryansch mentioned this issue May 20, 2015
Merged
@ryansch
Copy link
Contributor Author

ryansch commented May 20, 2015

Please see the new test added in #918.

@joaomdmoura joaomdmoura mentioned this issue Jun 16, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
S: Needs Bug Verification V: 0.10.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add rescue_from handler to clear state outstand/active_model_serializers
2 participants
@ryansch @joshsmith