Side loading data with embed_ids like 0.9

[ahmeij]

This is an initial version of a legacy adapter which aims for backwards compatibility with the embed_ids style json of 0.8 and 0.9.

Tests are still missing, I hope to be able to add them soon but I would appreciate any help.

I would appreciate some feedback to see what needs done/improved to get this merged. For our product this generates json that is once again compatible with our consumers.

This originated in issue #899

[joaomdmoura]

Hey @ahmeij, first of all, sorry for taken so long to get to this, and thank you for contributing! 😄
So, the idea of having one adapter (or even two) to support old formats pleases me because might be helpful to ppl that are trying to update to 0.10.x. But if the needs you have are related only to embed_ids, I thing #1114 might be the best suited, can you check the PR and help us to test it and check if it cover most of the edge cases? 😄

[ahmeij]

Hi @joaomdmoura, while previous versions of that PR where actually side loading, the current version has no side loading logic left. Next to that it does not implement the old 'filter' and serialisation_options logic.

I agree on trying to keep it all in one adapter. Probably best to wait until that PR is finished and merged and I'll try to make a new PR for the side-loading based on the then current adapter.

With the mayor changes coming to the json adapter this PR has become obsolete and can be closed for now.

[bf4]

(needs to be rebased off of master, some rearranging since then)

I'd like to make this sort of stuff available, but in an optional gem, so the 'current' and 'legacy' can be released separately

[beauby]

I definitely think we should have a legacy adapter, one way or another.

[bf4]

@ahmeij This is pretty good work. Would you like to continue it, off of current master? Let me know if i can help in any way.

[NullVoxPopuli]

Closing for now (just for cleanup of all the PRs). If you'd still like to work on this, please feel free to rebase, and reopen. :-)