Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor with_adapter + force cache clear before each test. #1093

Merged
merged 4 commits into from
Sep 7, 2015

Conversation

beauby
Copy link
Contributor

@beauby beauby commented Aug 28, 2015

No description provided.

@bf4
Copy link
Member

bf4 commented Aug 28, 2015

You might also want to check git grep load_adapter git grep Adapter.create git grep Adapter.new

@beauby
Copy link
Contributor Author

beauby commented Aug 29, 2015

@bf4 sure, I'll update all the tests if we decide to move forward on this.

@NullVoxPopuli
Copy link
Contributor

This looks fantastic!

@joaomdmoura
Copy link
Member

Nice, but need to rebase 😁

@beauby
Copy link
Contributor Author

beauby commented Sep 1, 2015

Rebased! 👍

@joaomdmoura
Copy link
Member

Sorry about it @beauby can you rebase it again please? last time, I promisse 😁

@beauby
Copy link
Contributor Author

beauby commented Sep 7, 2015

Rebased 👍

joaomdmoura added a commit that referenced this pull request Sep 7, 2015
Factor `with_adapter` + force cache clear before each test.
@joaomdmoura joaomdmoura merged commit f149e50 into rails-api:master Sep 7, 2015
@joaomdmoura
Copy link
Member

Tks! merged! 😄

@bf4 bf4 deleted the improve-tests branch December 23, 2015 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants