Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Style enforcer (via Rubocop) #1106

Merged
merged 6 commits into from
Sep 5, 2015
Merged

Conversation

bf4
Copy link
Member

@bf4 bf4 commented Aug 31, 2015

It will fail the build, but as it is currently, most of the cops are
'todos'. Great for new contributors.. :)

Style/StringLiterals single quote all the things

@beauby
Copy link
Contributor

beauby commented Aug 31, 2015

👍

@bf4 bf4 force-pushed the style_checking branch 2 times, most recently from b51cb16 to 884d643 Compare August 31, 2015 09:28
bf4 added 4 commits September 3, 2015 20:50
It will fail the build, but as it is currently,
most of the cops are 'todos'. Great for new contributors.. :)
@bf4
Copy link
Member Author

bf4 commented Sep 4, 2015

There interest in this?


def create_serializer_file
template 'serializer.rb', File.join('app/serializers', class_path, "#{file_name}_serializer.rb")
template 'serializer.rb.erb', File.join('app/serializers', class_path, "#{file_name}_serializer.rb")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@joaomdmoura
Copy link
Member

Never used Rubocop but it seems really nice. This will help into get new ppl to contribute to it 😄.
Only got scared with the _todo.yml file. Binding it to travis was nice as well!

joaomdmoura added a commit that referenced this pull request Sep 5, 2015
Add Style enforcer (via Rubocop)
@joaomdmoura joaomdmoura merged commit f227994 into rails-api:master Sep 5, 2015
@bf4 bf4 deleted the style_checking branch August 31, 2016 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants