Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Rubocop todo #1183

Merged
merged 2 commits into from
Sep 21, 2015
Merged

Update Rubocop todo #1183

merged 2 commits into from
Sep 21, 2015

Conversation

bf4
Copy link
Member

@bf4 bf4 commented Sep 20, 2015 

+Style/BlockDelimiters:
+  Enabled: true
+  EnforcedStyle: line_count_based

ref: https://github.com/bbatsov/rubocop/blob/748a11c2508aa513ed64af317552accd404870da/config/default.yml#L170-L234

@bf4 bf4 mentioned this pull request Sep 20, 2015
Merged
@NullVoxPopuli
Copy link
Contributor

👍

@beauby
Copy link
Contributor

beauby commented Sep 21, 2015

I for one really prefer the semantic style.

@bf4 bf4 mentioned this pull request Sep 21, 2015
Merged
NullVoxPopuli added a commit that referenced this pull request Sep 21, 2015
@NullVoxPopuli
Merge pull request #1183 from rails-api/block_style
8f2dd66 
Update Rubocop todo
@NullVoxPopuli NullVoxPopuli merged commit 8f2dd66 into master Sep 21, 2015
@NullVoxPopuli NullVoxPopuli deleted the block_style branch September 21, 2015 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C: Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bf4 @NullVoxPopuli @beauby