Update rubocop

[groyoh]

Purpose

Rebase #1498

Related GitHub issues

Closes #1498

Additional helpful information

@bf4 @remear here you go 😄 Just need to update the trailling/leading dot and add a CHANGELOG. Anything else missing?

[groyoh]

Rubocop changed this to:

ADAPTER_MAP = {}.freeze

which prevent us to modify the hash at line 52 and thus breaks the gem/tests.

[bf4]

:)

[bf4]

test/action_controller/serialization_test.rb:435:7: W: Lint/UnneededDisable: Unnecessary disabling of Lint/DuplicateMethods.
      # rubocop:disable Lint/DuplicateMethods
      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
148 files inspected, 1 offense detected

womp wmp

[groyoh]

Weird, rubocop is green locally 😕

[groyoh]

Ah found it, it was 0.37 locally but 0.37.2 on Travis.

[groyoh]

@bf4 What do you think about pinning the rubocop version?

[bf4]

Depends if it's broken and causing trouble or just different

B mobile phone

On Mar 7, 2016, at 5:28 PM, Yohan Robert [email protected] wrote:

@bf4 What do you think about pinning the rubocop version?

—
Reply to this email directly or view it on GitHub.

[groyoh]

I assume new cops are added every few versions so if the version is not fixed, then we might run into new cops every now and then, making the build fail.

[groyoh]

As @remear I tend to prefer leading here. what about you @bf4?

[NullVoxPopuli]

needs rebase -- as long as the checks pass, I'm good with merging.

[remear]

Is the trailing comma what all the cool kids do these days? https://github.com/rails-api/active_model_serializers/pull/1560/files#diff-57dc91570125bb0a036a83a5c8bd6be8R63

Usually I'm fine with it being allowed, not necessarily required, as is a habit I picked up from Python for this. I'm curious if others have any strong opinion here.

[NullVoxPopuli]

I'm personally not a fan of the trailing comma. But I guess if that's what the standard is now a days...

[remear]

Sounds like the team prefers the DotPosition before, e.g.,

SomeClass.awesome_sauce
 .do_things

The team also prefers to not enforce a trailing comma.

[groyoh]

Rebased and updated with the style fix.

[remear]

👍

[NullVoxPopuli]

I'm good with this.

[NullVoxPopuli]

do we want to merge anything before we merge this, as it could cause conflicts in other PRs?

[groyoh]

@NullVoxPopuli good point here. IMO, it would be easier to merge this first and update the other PR as this one is pretty big.