Use serializer name instead of model name to create fragment cache serializers #1622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this PR! I've been wanting to roll it out myself for quite some time now. Could you add an entry within the CHANGELOG in the |
| @@ -139,6 +139,11 @@ def slug | |||
| belongs_to :author | |||
| end | |||
|
|
|||
| InheritedRoleSerializer = Class.new(RoleSerializer) do | |||
There was a problem hiding this comment.
Could you move this class to test/cache_test.rb to avoid bloating this file?
|
@lserman awesome work! Please address comments, squash down to one commit, and this is ready to merge! 💯 |
|
@bf4 thank you, hope I did that squash right... never done this before. |
| InheritedRoleSerializer = Class.new(RoleSerializer) do | ||
| cache key: 'inherited_role', only: [:name, :special_attribute] | ||
| attribute :special_attribute | ||
| end |
There was a problem hiding this comment.
Better to include this in the class CacheTest so it's not in the global scope, but not a blocker
|
@lserman 💯 you're doing a fantastic job! |
| @@ -79,10 +79,12 @@ def add_attributes_to_serializer(serializer, attributes, attributes_keys) | |||
| # User_AdminCachedSerializer | |||
There was a problem hiding this comment.
The doc should also be changed accordingly 😉
bf4
added a commit
that referenced
this pull request
Mar 30, 2016
Followup needed: - Update code comments #1622 (comment) - Move test class into test scope #1622 (comment)
|
Merged! 🌈 @lserman |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1621