Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds a code of conduct #1812

Closed

Conversation

CorainChicago
Copy link
Contributor

Purpose

An easy way to begin addressing the problem of inclusivity is to be overt in our
openness, welcoming all people to contribute, and pledging in return to
value them as human beings and to foster an atmosphere of kindness,
cooperation, and understanding.

A code of conduct is one way to express these values. It lets us pledge
our respect and appreciation for contributors and participants to the
project.

Changes

Add the Contributor Covenant

Caveats

Related GitHub issues

Additional helpful information

It's the code of conduct adapted by Rails.

## Enforcement

Instances of abusive, harassing, or otherwise unacceptable behavior may be
reported by contacting the project team in our [Slack Channel](93e2475232ce581889da767f72c27e9664482a4a). All
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you meant to link to the community slack? https://github.com/rails-api/active_model_serializers/#getting-help

@CorainChicago CorainChicago force-pushed the code_of_conduct branch 2 times, most recently from 0badf0e to 00304c3 Compare June 17, 2016 01:16
@CorainChicago
Copy link
Contributor Author

I moved the change log to the unreleased section, fixed the link to the slack invite and kept it all in one commit too.

## Enforcement

Instances of abusive, harassing, or otherwise unacceptable behavior may be
reported by contacting the project team in our [Slack Channel](http://amserializers.herokuapp.com/). All
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather link to where we define this in our docs so it doesn't get out of sync. Mind adding to the readme

<a name="chat"></a>

If you'd like to chat, we have a [community slack](http://amserializers.herokuapp.com).

so you can link here like

[Slack Channel](README.md#chat)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But the practical problem with this is that it doesn't say whom to contact once in the slack. That's why I think it may make more sense to say

Contact one of the owners listed at https://rubygems.org/gems/active_model_serializers

add contact information to the code of conduct

update change log
@CorainChicago
Copy link
Contributor Author

I agreed with linking to the rubygem page - a person can know who to contact and email them directly. :)

@jgrau jgrau mentioned this pull request Aug 31, 2016
@bf4 bf4 closed this Aug 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants