Reimplement serialization scope and scope_name #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks pretty straightforward to me. @kurko what do you think? |
|
This is probably the only thing keeping me from upgrading to AMS master. I'd like thoughts from @kurko or @guilleiguaran or @joaomdmoura before just giving this the 👍 |
| end | ||
|
|
||
| def serialization_scope | ||
| send(_serialization_scope) if _serialization_scope && |
There was a problem hiding this comment.
if possible, use public_send instead 😄
|
Thanks for help @joaomdmoura 🍻 |
|
No worries. You can count on me 🍻 |
guilleiguaran
added a commit
that referenced
this pull request
Mar 10, 2015
Reimplement serialization scope and scope_name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've more or less directly dropped in the code, and I'm open to discussing alternate approaches; I will provide tests once the direction is settled.