Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare v2.4.0 Release #22

Merged
merged 65 commits into from
Apr 1, 2020
Merged

Prepare v2.4.0 Release #22

merged 65 commits into from
Apr 1, 2020

Conversation

rpbaltazar
Copy link
Contributor

No description provided.

- Fixes CI runs:
  - One of the rails versions [had a bug](rails/rails#38137) and causes the CI to fail. I've moved it to the allowed failures.
  - I think we should deprecate these versions as they are EOL. => New ticket to be created
- Fixes rubocop installation - I had not realized when I merged rubocop installation that I was breaking all CI (I'm sorry for the rushed decision). This fixes the dependencies and all CI should be passing.
- Adds rubocop to github actions. All the rubocop failures will be fixed with #8
rpbaltazar and others added 29 commits February 17, 2020 11:51
…-only-run-pr-s-in-12

[Resolves #12] Update travis config to only run PRs instead of all commits

- Updated travis.yml to run only for branches: `master` and `development`.
- Due to the nature of PRs, nothing needs to be done to ensure tests run against an open PR
Don't crash when no database connection is present
Rakefile should use mysql port from configuration
@rpbaltazar rpbaltazar merged commit b39c183 into master Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants