Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also match custom default tenant on PSQL_DUMP_BLACKLISTED_STATEMENTS #293

Conversation

rbngzlv
Copy link
Contributor

@rbngzlv rbngzlv commented Oct 27, 2024

When using a default_tenant different than public, cloning the schema to the new one fails because the included CREATE SCHEMA ... by the pg_dump is not removed before restoring it.

Fixes #164

Note: created as draft while specs are refactored and merged (#292)

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.54%. Comparing base (4a58bb3) to head (1d90830).
Report is 1 commits behind head on development.

Additional details and impacted files
@@               Coverage Diff               @@
##           development     #293      +/-   ##
===============================================
- Coverage        82.83%   79.54%   -3.29%     
===============================================
  Files               35       35              
  Lines              874      885      +11     
===============================================
- Hits               724      704      -20     
- Misses             150      181      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mnovelo mnovelo marked this pull request as ready for review October 30, 2024 13:10
@mnovelo mnovelo merged commit ec5a9bc into rails-on-services:development Oct 30, 2024
73 of 85 checks passed
@rbngzlv rbngzlv deleted the create_tenant_with_default_tenant branch October 30, 2024 13:14
@rbngzlv
Copy link
Contributor Author

rbngzlv commented Oct 30, 2024

Thank you @mnovelo .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add default_tenant to PSQL_DUMP_BLACKLISTED_STATEMENTS
2 participants