Support rails 6.1 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jean-francois-labbe I've fixed Rubocop and CI. All should be passing now. Sorry for the merge conflict. |
|
Looking at your code, I understand where the problem comes from. I'm not sure how will this rails/rails@c5ecc33#diff-a15c218db8b9dd9f84a75d9a3894db56L30 code run. Unless I'm missing something, this almost feels like a rails bug |
jean-francois-labbe
force-pushed
the
fix-rails-6-1
branch
from
21d87ca to
b11583a
Compare
jean-francois-labbe
force-pushed
the
fix-rails-6-1
branch
from
b11583a to
54c9c72
Compare
|
@jean-francois-labbe this is not forgotten. Just trying to clean up the development branch first and will put this under a major release |
rpbaltazar
approved these changes
Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6
This is a working fix but may not be the best way to implement it.
Basically it restores the
table_exists?Functions.