Skip to content

Commit

Permalink
Remove test_order method check in test/helper.rb
Browse files Browse the repository at this point in the history
* currently globalid is depending on 'activesupport >= 5.0', which makes the `ActiveSupport::TestCase.respond_to?(:test_order=)` check redundant
* in `activesupport > 4.1.16, < 5.0` , `ActiveSupport::TestCase.test_order` default to `:sorted`, but in 'activesupport >= 5.0', its default is `:random`, so these thress lines of code can be removed
  • Loading branch information
liijunwei committed Nov 1, 2022
1 parent 5da6355 commit 99d4166
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions test/helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,6 @@

require 'json'

if ActiveSupport::TestCase.respond_to?(:test_order=)
# TODO: remove check once ActiveSupport dependency is at least 4.2
ActiveSupport::TestCase.test_order = :random
end

GlobalID.app = 'bcx'

# Default serializers is Marshal, whose format changed 1.9 -> 2.0,
Expand Down

0 comments on commit 99d4166

Please sign in to comment.