Move inline styles to stylesheet

rails · Oct 31, 2024 · b89f01f · b89f01f
1 parent 07fe9ce
commit b89f01f
Show file tree

Hide file tree

Showing 7 changed files with 40 additions and 11 deletions.
diff --git a/app/assets/stylesheets/mission_control/jobs/jobs.css b/app/assets/stylesheets/mission_control/jobs/jobs.css
@@ -2,6 +2,35 @@
     width: 15rem;
 }
 
-.jobs td {
-    word-break: break-all;
+table.jobs {
+    td {
+        word-break: break-all;
+    }
+    th.job-header{
+        width: 30%;
+    }
+    th.duration-header {
+        width: 20%;
+    }
+    &.queues th.job-header {
+        width: 30%;
+    }
+    &.failed th.job-header {
+        width: 35%;
+    }
+    &.in_progress th.job-header {
+        width: 50%;
+    }
+    &.blocked th.job-header {
+        width: 45%;
+    }
+    &.scheduled th.job-header {
+        width: 60%;
+    }
+    &.finished th.job-header {
+        width: 65%;
+    }
+    &.workers th.job-header {
+        width: 40%;
+    }
 }
diff --git a/app/views/mission_control/jobs/jobs/_filters.html.erb b/app/views/mission_control/jobs/jobs/_filters.html.erb
@@ -14,13 +14,13 @@
 
         <%= hidden_field_tag :server_id, MissionControl::Jobs::Current.server.id %>
 
-        <datalist id="job-classes" style="display: none;">
+        <datalist id="job-classes" class="is-hidden">
           <% job_class_names.each do |job_class_name| %>
             <option value="<%= job_class_name %>" />
           <% end %>
         </datalist>
 
-        <datalist id="queue-names" style="display: none;">
+        <datalist id="queue-names" class="is-hidden">
           <% queue_names.each do |queue_name| %>
             <option value="<%= queue_name %>" />
           <% end %>

diff --git a/app/views/mission_control/jobs/jobs/_jobs_page.html.erb b/app/views/mission_control/jobs/jobs/_jobs_page.html.erb
@@ -1,7 +1,7 @@
 <table class="jobs <%= jobs_status %> table queues is-hoverable is-fullwidth">
   <thead>
     <tr>
-      <th style="width: 35%;">Job</th>
+      <th class="job-header">Job</th>
       <% attribute_names_for_job_status(jobs_status).each do |attribute| %>
         <th><%= attribute %></th>
       <% end %>

diff --git a/app/views/mission_control/jobs/queues/index.html.erb b/app/views/mission_control/jobs/queues/index.html.erb
@@ -4,8 +4,8 @@
   <tbody>
   <thead>
   <tr>
-    <th style="width: 50%;">Queue</th>
-    <th style="width: 30%;">Pending jobs</th>
+    <th>Queue</th>
+    <th>Pending jobs</th>
     <th></th>
   </tr>
   </thead>

diff --git a/app/views/mission_control/jobs/queues/show.html.erb b/app/views/mission_control/jobs/queues/show.html.erb
@@ -9,7 +9,7 @@
     <tbody>
     <thead>
     <tr>
-      <th style="width: 30%;">Job</th>
+      <th class="job-header">Job</th>
       <th></th>
     </tr>
     </thead>

diff --git a/app/views/mission_control/jobs/shared/_jobs.html.erb b/app/views/mission_control/jobs/shared/_jobs.html.erb
@@ -2,9 +2,9 @@
   <tbody>
   <thead>
   <tr>
-    <th style="width: 30%;">Job</th>
+    <th class="job-header">Job</th>
     <th></th>
-    <th style="width: 20%;"></th>
+    <th class="duration-header"></th>
   </tr>
   </thead>
 

diff --git a/app/views/mission_control/jobs/workers/_workers_page.html.erb b/app/views/mission_control/jobs/workers/_workers_page.html.erb
@@ -4,7 +4,7 @@
   <tr>
     <th>Worker</th>
     <th>Hostname</th>
-    <th style="width: 35%;">Jobs</th>
+    <th class="job-header">Jobs</th>
     <th>Last heartbeat</th>
   </tr>
   </thead>